Sign upLogin

cloudfoundry-incubator/stratos

View on GitHub
Star
src/jetstream/plugins/kubernetes/dashboard/proxy.go

Summary

Maintainability
B
5 hrs
Test Coverage

Function KubeDashboardProxy has 81 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func KubeDashboardProxy(c echo.Context, p interfaces.PortalProxy, config *rest.Config) error {
    log.Debugf("KubeDashboardProxy request for: %s", c.Request().RequestURI)

    cnsiGUID := c.Param("guid")
    prefix := "/pp/v1/apps/kubedash/ui/" + cnsiGUID + "/"
Severity: Major
Found in src/jetstream/plugins/kubernetes/dashboard/proxy.go - About 2 hrs to fix

    Function KubeDashboardProxy has a Cognitive Complexity of 18 (exceeds 8 allowed). Consider refactoring.
    Open

    func KubeDashboardProxy(c echo.Context, p interfaces.PortalProxy, config *rest.Config) error {
    log.Debugf("KubeDashboardProxy request for: %s", c.Request().RequestURI)

    cnsiGUID := c.Param("guid")
    prefix := "/pp/v1/apps/kubedash/ui/" + cnsiGUID + "/"
    Severity: Minor
    Found in src/jetstream/plugins/kubernetes/dashboard/proxy.go - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function KubeDashboardProxy has 8 return statements (exceeds 4 allowed).
    Open

    func KubeDashboardProxy(c echo.Context, p interfaces.PortalProxy, config *rest.Config) error {
    log.Debugf("KubeDashboardProxy request for: %s", c.Request().RequestURI)

    cnsiGUID := c.Param("guid")
    prefix := "/pp/v1/apps/kubedash/ui/" + cnsiGUID + "/"
    Severity: Major
    Found in src/jetstream/plugins/kubernetes/dashboard/proxy.go - About 50 mins to fix

      TODO found
      Open

                  // TODO: Check the value for the cookie header - kube dash may well update with the value
      Severity: Minor
      Found in src/jetstream/plugins/kubernetes/dashboard/proxy.go by fixme

      There are no issues that match your filters.

      Category
      Status