Sign upLogin

cloudfoundry-incubator/stratos

View on GitHub
Star
src/jetstream/plugins/kubernetes/terminal/cleanup.go

Summary

Maintainability
C
1 day
Test Coverage

Method KubeTerminal.cleanup has a Cognitive Complexity of 58 (exceeds 8 allowed). Consider refactoring.
Open

func (k *KubeTerminal) cleanup() {
    // Use a random initial wait before cleaning up
    // If we had more than one backend, this helps to ensure they are not all trying to cleanup at the same time
    wait := rand.Intn(30)
    log.Debug("Kubernetes Terminal cleanup will start in %d minutes", wait)
Severity: Minor
Found in src/jetstream/plugins/kubernetes/terminal/cleanup.go - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method KubeTerminal.cleanup has 51 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (k *KubeTerminal) cleanup() {
    // Use a random initial wait before cleaning up
    // If we had more than one backend, this helps to ensure they are not all trying to cleanup at the same time
    wait := rand.Intn(30)
    log.Debug("Kubernetes Terminal cleanup will start in %d minutes", wait)
Severity: Minor
Found in src/jetstream/plugins/kubernetes/terminal/cleanup.go - About 1 hr to fix

    Avoid deeply nested control flow statements.
    Open

                            if err == nil {
                            isValid, err := k.PortalProxy.GetSessionDataStore().IsValidSession(i)
                            if err == nil && !isValid {
                                log.Debugf("Deleting pod %s", pod.Name)
                                podClient.Delete(pod.Name, nil)
    Severity: Major
    Found in src/jetstream/plugins/kubernetes/terminal/cleanup.go - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                              if err == nil {
                            isValid, err := k.PortalProxy.GetSessionDataStore().IsValidSession(i)
                            if err == nil && !isValid {
                                log.Debugf("Deleting secret %s", secret.Name)
                                secretClient.Delete(secret.Name, nil)
      Severity: Major
      Found in src/jetstream/plugins/kubernetes/terminal/cleanup.go - About 45 mins to fix

        There are no issues that match your filters.

        Category
        Status