Sign upLogin

cloudfoundry-incubator/stratos

View on GitHub
Star
src/jetstream/repository/console_config/env_lookup.go

Summary

Maintainability
B
4 hrs
Test Coverage

Function MigrateSetupData has a Cognitive Complexity of 16 (exceeds 8 allowed). Consider refactoring.
Open

func MigrateSetupData(portal interfaces.PortalProxy, configStore Repository) error {

    // Determine if we need to migrate data first
    _, ok, err := configStore.GetValue(systemGroupName, configSetupNeededMarker)
    if err != nil {
Severity: Minor
Found in src/jetstream/repository/console_config/env_lookup.go - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function MigrateSetupData has 15 return statements (exceeds 4 allowed).
Open

func MigrateSetupData(portal interfaces.PortalProxy, configStore Repository) error {

    // Determine if we need to migrate data first
    _, ok, err := configStore.GetValue(systemGroupName, configSetupNeededMarker)
    if err != nil {
Severity: Major
Found in src/jetstream/repository/console_config/env_lookup.go - About 1 hr to fix

    Function MigrateSetupData has 56 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func MigrateSetupData(portal interfaces.PortalProxy, configStore Repository) error {

    // Determine if we need to migrate data first
    _, ok, err := configStore.GetValue(systemGroupName, configSetupNeededMarker)
    if err != nil {
    Severity: Minor
    Found in src/jetstream/repository/console_config/env_lookup.go - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status