Sign upLogin

cloudfoundry-incubator/stratos

View on GitHub
Star
src/jetstream/repository/interfaces/structs.go

Summary

Maintainability
A
2 hrs
Test Coverage

Method ConsoleConfig.IsSetupComplete has a Cognitive Complexity of 17 (exceeds 8 allowed). Consider refactoring.
Open

func (consoleConfig *ConsoleConfig) IsSetupComplete() bool {

    // No auth, then setup is complete
    if AuthEndpointTypes[consoleConfig.AuthEndpointType] == AuthNone {
        return true
Severity: Minor
Found in src/jetstream/repository/interfaces/structs.go - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method ConsoleConfig.IsSetupComplete has 5 return statements (exceeds 4 allowed).
Open

func (consoleConfig *ConsoleConfig) IsSetupComplete() bool {

    // No auth, then setup is complete
    if AuthEndpointTypes[consoleConfig.AuthEndpointType] == AuthNone {
        return true
Severity: Major
Found in src/jetstream/repository/interfaces/structs.go - About 35 mins to fix

    TODO found
    Open

    //TODO this could be moved back to cnsis subpackage, and extensions could import it?
    Severity: Minor
    Found in src/jetstream/repository/interfaces/structs.go by fixme

    There are no issues that match your filters.

    Category
    Status