Sign upLogin

cloudfoundry/cf

View on GitHub
Star
lib/manifests/plugin.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method wrap_with_optional_name has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

  def wrap_with_optional_name(name_made_optional, cmd, input, fail_without_app)
    return cmd.call if input[:all]

    unless manifest
      # if the command knows how to handle this
Severity: Minor
Found in lib/manifests/plugin.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method wrap_push has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  def wrap_push(push, input)
    unless manifest
      create_and_save_manifest(push, input)
      return
    end
Severity: Minor
Found in lib/manifests/plugin.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

    return no_apps if fail_without_app && apps.empty?
Severity: Major
Found in lib/manifests/plugin.rb - About 30 mins to fix

    There are no issues that match your filters.

    Category
    Status