cloudfoundry/cf

View on GitHub
lib/tunnel/tunnel.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Class CFTunnel has 22 methods (exceeds 20 allowed). Consider refactoring.
Open

class CFTunnel
  HELPER_NAME = "caldecott"
  HELPER_APP = File.expand_path("../helper-app", __FILE__)

  # bump this AND the version info reported by HELPER_APP/server.rb
Severity: Minor
Found in lib/tunnel/tunnel.rb - About 2 hrs to fix

    Method get_connection_info has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def get_connection_info(token)
        response = nil
        10.times do
          begin
            response =
    Severity: Minor
    Found in lib/tunnel/tunnel.rb - About 1 hr to fix

      Method get_connection_info has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

        def get_connection_info(token)
          response = nil
          10.times do
            begin
              response =
      Severity: Minor
      Found in lib/tunnel/tunnel.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method open! has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        def open!
          if helper
            auth = helper_auth
      
            unless helper_healthy?(auth)
      Severity: Minor
      Found in lib/tunnel/tunnel.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status