Sign upLogin

cloudfoundry/cloud_controller_ng

View on GitHub
Star
app/actions/app_create.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method create has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def create(message, lifecycle)
      app = nil
      AppModel.db.transaction do
        app = AppModel.create(
          name: message.name,
Severity: Minor
Found in app/actions/app_create.rb - About 1 hr to fix

    Method validate_buildpacks_are_ready has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def validate_buildpacks_are_ready(app)
      return unless app.buildpack_lifecycle_data

      app.buildpack_lifecycle_data.buildpack_lifecycle_buildpacks.each do |blb|
        next if blb.custom?
    Severity: Minor
    Found in app/actions/app_create.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method create has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def create(message, lifecycle)
      app = nil
      AppModel.db.transaction do
        app = AppModel.create(
          name: message.name,
    Severity: Minor
    Found in app/actions/app_create.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status