Sign upLogin

cloudfoundry/cloud_controller_ng

View on GitHub
Star
app/actions/deployment_create.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Method create has 52 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def create(app:, user_audit_info:, message:)
        deployment = nil

        DeploymentModel.db.transaction do
          app.lock!
Severity: Major
Found in app/actions/deployment_create.rb - About 2 hrs to fix

    Method clone_existing_web_process has 48 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def clone_existing_web_process(app, revision, process_instances)
        web_process = app.newest_web_process
        command = if revision
                    revision.commands_by_process_type[ProcessTypes::WEB]
                  else
    Severity: Minor
    Found in app/actions/deployment_create.rb - About 1 hr to fix

      Method create has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

            def create(app:, user_audit_info:, message:)
        deployment = nil

        DeploymentModel.db.transaction do
          app.lock!
      Severity: Minor
      Found in app/actions/deployment_create.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method deployment_for_stopped_app has 7 arguments (exceeds 4 allowed). Consider refactoring.
      Open

            def deployment_for_stopped_app(app, message, previous_deployment, previous_droplet, revision, target_state, user_audit_info)
      Severity: Major
      Found in app/actions/deployment_create.rb - About 50 mins to fix

        There are no issues that match your filters.

        Category
        Status