Sign upLogin

cloudfoundry/cloud_controller_ng

View on GitHub
Star
app/actions/manifest_route_update.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Method update has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

      def update(app_guid, message, user_audit_info)
        return unless message.requested?(:routes)

        app = AppModel.find(guid: app_guid)
        not_found! unless app
Severity: Minor
Found in app/actions/manifest_route_update.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method update has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def update(app_guid, message, user_audit_info)
        return unless message.requested?(:routes)

        app = AppModel.find(guid: app_guid)
        not_found! unless app
Severity: Minor
Found in app/actions/manifest_route_update.rb - About 1 hr to fix

    Method find_or_create_valid_route has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def find_or_create_valid_route(app, manifest_route, user_audit_info)
        manifest_route[:candidate_host_domain_pairs].each do |candidate|
          potential_domain = candidate[:domain]
          existing_domain = Domain.find(name: potential_domain)
          next unless existing_domain
    Severity: Minor
    Found in app/actions/manifest_route_update.rb - About 1 hr to fix

      Method find_or_create_valid_route has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

            def find_or_create_valid_route(app, manifest_route, user_audit_info)
        manifest_route[:candidate_host_domain_pairs].each do |candidate|
          potential_domain = candidate[:domain]
          existing_domain = Domain.find(name: potential_domain)
          next unless existing_domain
      Severity: Minor
      Found in app/actions/manifest_route_update.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status