Sign upLogin

cloudfoundry/cloud_controller_ng

View on GitHub
Star
app/actions/v2/services/service_binding_create.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method create has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    def create(app, service_instance, message, volume_mount_services_enabled, accepts_incomplete)
      raise ServiceInstanceNotBindable unless service_instance.bindable?
      raise VolumeMountServiceDisabled if service_instance.volume_service? && !volume_mount_services_enabled
      raise SpaceMismatch unless bindable_in_space?(service_instance, app.space)
Severity: Minor
Found in app/actions/v2/services/service_binding_create.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method create has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def create(app, service_instance, message, volume_mount_services_enabled, accepts_incomplete)
      raise ServiceInstanceNotBindable unless service_instance.bindable?
      raise VolumeMountServiceDisabled if service_instance.volume_service? && !volume_mount_services_enabled
      raise SpaceMismatch unless bindable_in_space?(service_instance, app.space)
Severity: Minor
Found in app/actions/v2/services/service_binding_create.rb - About 1 hr to fix

    Method create has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def create(app, service_instance, message, volume_mount_services_enabled, accepts_incomplete)
    Severity: Minor
    Found in app/actions/v2/services/service_binding_create.rb - About 35 mins to fix

      There are no issues that match your filters.

      Category
      Status