Sign upLogin

cloudfoundry/cloud_controller_ng

View on GitHub
Star
app/controllers/internal/syslog_drain_urls_controller.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method listv5 has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def listv5
      prepare_aggregate_function

      bindings = ServiceBinding.
                 join(:apps, guid: :app_guid).
Severity: Minor
Found in app/controllers/internal/syslog_drain_urls_controller.rb - About 1 hr to fix

    Method list has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def list
      prepare_aggregate_function
      guid_to_drain_maps = AppModel.
                           join(ServiceBinding.table_name, app_guid: :guid).
                           join(Space.table_name, guid: :apps__space_guid).
    Severity: Minor
    Found in app/controllers/internal/syslog_drain_urls_controller.rb - About 1 hr to fix

      Method fetch_credentials_from_cache has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          def fetch_credentials_from_cache(item)
      if item[:is_managed_service]
        credentials = item.credentials
        cert = credentials&.fetch('cert', '') || ''
        key = credentials&.fetch('key', '') || ''
      Severity: Minor
      Found in app/controllers/internal/syslog_drain_urls_controller.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status