Sign upLogin

cloudfoundry/cloud_controller_ng

View on GitHub
Star
app/controllers/runtime/organization_summaries_controller.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method summary has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def summary(guid)
      org = find_guid_and_validate_access(:read, guid)
      spaces = visible_spaces(org).map do |space|
        # when we do the quota work, this and the service counts will be kept
        # as a running total so that we don't have to compute them on the
Severity: Minor
Found in app/controllers/runtime/organization_summaries_controller.rb - About 1 hr to fix

    Method summary has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def summary(guid)
      org = find_guid_and_validate_access(:read, guid)
      spaces = visible_spaces(org).map do |space|
        # when we do the quota work, this and the service counts will be kept
        # as a running total so that we don't have to compute them on the
    Severity: Minor
    Found in app/controllers/runtime/organization_summaries_controller.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status