Sign upLogin

cloudfoundry/cloud_controller_ng

View on GitHub
Star
app/controllers/v3/application_controller.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Class ApplicationController has 26 methods (exceeds 20 allowed). Consider refactoring.
Open

class ApplicationController < ActionController::Base
  include VCAP::CloudController
  include V3ErrorsHelper
  include VCAP::CloudController::ParamsHashifier
Severity: Minor
Found in app/controllers/v3/application_controller.rb - About 3 hrs to fix

    Method check_utf8_encoding! has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

      def check_utf8_encoding!(yaml_data)
    if yaml_data.is_a?(Hash)
      yaml_data.each_value do |value|
        check_utf8_encoding!(value)
      end
    Severity: Minor
    Found in app/controllers/v3/application_controller.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method parsed_yaml has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

      def parsed_yaml
    return @parsed_yaml if @parsed_yaml

    bad_request!('Manifest size is too large. The maximum supported size is 1MB.') if request.body.size > 1.megabyte
    Severity: Minor
    Found in app/controllers/v3/application_controller.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status