Sign upLogin

cloudfoundry/cloud_controller_ng

View on GitHub
Star
app/fetchers/droplet_list_fetcher.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method filter has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

      def filter(message, app, space_guids, dataset)
        if message.requested?(:current) && app
          dataset = dataset.extension(:null_dataset)
          return dataset.nullify unless app.droplet
Severity: Minor
Found in app/fetchers/droplet_list_fetcher.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method filter has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def filter(message, app, space_guids, dataset)
        if message.requested?(:current) && app
          dataset = dataset.extension(:null_dataset)
          return dataset.nullify unless app.droplet
Severity: Minor
Found in app/fetchers/droplet_list_fetcher.rb - About 1 hr to fix

    Method scoped_space_guids has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

          def scoped_space_guids(permitted_space_guids:, filtered_space_guids:)
        return nil unless permitted_space_guids || filtered_space_guids
        return filtered_space_guids & permitted_space_guids if filtered_space_guids && permitted_space_guids
        return permitted_space_guids if permitted_space_guids
    Severity: Minor
    Found in app/fetchers/droplet_list_fetcher.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status