Sign upLogin

cloudfoundry/cloud_controller_ng

View on GitHub
Star
app/jobs/runtime/orphaned_blobs_cleanup.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method cleanup has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

        def cleanup(day_of_week)
          logger.info("Started orphaned blobs cleanup job for day of week: #{day_of_week}")

          update_existing_orphaned_blobs
Severity: Minor
Found in app/jobs/runtime/orphaned_blobs_cleanup.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method unique_blobstores has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def unique_blobstores
          return @unique_blobstores if @unique_blobstores.present?

          full_list = [
            {
Severity: Minor
Found in app/jobs/runtime/orphaned_blobs_cleanup.rb - About 1 hr to fix

    Method cleanup has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            def cleanup(day_of_week)
          logger.info("Started orphaned blobs cleanup job for day of week: #{day_of_week}")

          update_existing_orphaned_blobs
    Severity: Minor
    Found in app/jobs/runtime/orphaned_blobs_cleanup.rb - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status