Sign upLogin

cloudfoundry/cloud_controller_ng

View on GitHub
Star
app/messages/manifest_service_binding_create_message.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method has_valid_hash_keys has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    def has_valid_hash_keys(service)
      valid_service_binding_keys = %i[name parameters binding_name]
      return false unless service.is_a?(Hash)
      return false unless service.length <= valid_service_binding_keys.length && service.keys.all? { |key| valid_service_binding_keys.include?(key) }
      return false unless service.key?(:name)
Severity: Minor
Found in app/messages/manifest_service_binding_create_message.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

      return false unless has_valid_optional_binding_name(service)
Severity: Major
Found in app/messages/manifest_service_binding_create_message.rb - About 30 mins to fix

    There are no issues that match your filters.

    Category
    Status