Sign upLogin

cloudfoundry/cloud_controller_ng

View on GitHub
Star
app/messages/role_create_message.rb

Summary

Maintainability
A
50 mins
Test Coverage

Method user_input_combinations has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

      def user_input_combinations
        errors.add(:username, 'cannot be specified when identifying user by guid') if has_user_guid? && has_username?

        errors.add(:user_origin, 'cannot be specified when identifying user by guid') if has_user_guid? && has_user_origin?
Severity: Minor
Found in app/messages/role_create_message.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method organization_or_space_input_combinations has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

      def organization_or_space_input_combinations
        errors.add(:base, 'must specify either a space or an organization.') if space_data.nil? && organization_data.nil?

        errors.add(:space, "cannot be provided with the organization role type: '#{type}'.") if space_data && VCAP::CloudController::RoleTypes::ORGANIZATION_ROLES.include?(type)
Severity: Minor
Found in app/messages/role_create_message.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status