Sign upLogin

cloudfoundry/cloud_controller_ng

View on GitHub
Star
app/messages/route_update_destinations_message.rb

Summary

Maintainability
A
4 hrs
Test Coverage

Method validate_destination_contents has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    def validate_destination_contents
      app_to_ports_hash = {}

      destinations.each_with_index do |dst, index|
        unless dst.is_a?(Hash)
Severity: Minor
Found in app/messages/route_update_destinations_message.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method validate_destination_contents has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def validate_destination_contents
      app_to_ports_hash = {}

      destinations.each_with_index do |dst, index|
        unless dst.is_a?(Hash)
Severity: Minor
Found in app/messages/route_update_destinations_message.rb - About 1 hr to fix

    Method validate_weight has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def validate_weight(destination_index, weight)
      return unless weight

      unless @replace
        add_destination_error(destination_index, 'weighted destinations can only be used when replacing all destinations.')
    Severity: Minor
    Found in app/messages/route_update_destinations_message.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status