Sign upLogin

cloudfoundry/cloud_controller_ng

View on GitHub
Star
app/repositories/deployment_event_repository.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method record_create has 8 arguments (exceeds 4 allowed). Consider refactoring.
Open

      def self.record_create(deployment, droplet, user_audit_info, v3_app_name, space_guid, org_guid, params, type)
Severity: Major
Found in app/repositories/deployment_event_repository.rb - About 1 hr to fix

    Method record_continue has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

          def self.record_continue(deployment, droplet, user_audit_info, v3_app_name, space_guid, org_guid)
    Severity: Minor
    Found in app/repositories/deployment_event_repository.rb - About 45 mins to fix

      Method record_cancel has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

            def self.record_cancel(deployment, droplet, user_audit_info, v3_app_name, space_guid, org_guid)
      Severity: Minor
      Found in app/repositories/deployment_event_repository.rb - About 45 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              def self.record_continue(deployment, droplet, user_audit_info, v3_app_name, space_guid, org_guid)
        VCAP::AppLogEmitter.emit(deployment.app_guid, "Continuing deployment for app with guid #{deployment.app_guid}")

        metadata = {
          deployment_guid: deployment.guid,
        Severity: Major
        Found in app/repositories/deployment_event_repository.rb and 1 other location - About 1 hr to fix
        app/repositories/deployment_event_repository.rb on lines 34..55

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 53.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              def self.record_cancel(deployment, droplet, user_audit_info, v3_app_name, space_guid, org_guid)
        VCAP::AppLogEmitter.emit(deployment.app_guid, "Cancelling deployment for app with guid #{deployment.app_guid}")

        metadata = {
          deployment_guid: deployment.guid,
        Severity: Major
        Found in app/repositories/deployment_event_repository.rb and 1 other location - About 1 hr to fix
        app/repositories/deployment_event_repository.rb on lines 58..79

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 53.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status