Sign upLogin

cloudfoundry/cloud_controller_ng

View on GitHub
Star
db/migrations/20130131184954_new_initial_schema.rb

Summary

Maintainability
A
2 hrs
Test Coverage

FIXME found
Open

      # FIXME: these defaults are going to move out of here and into
Severity: Minor
Found in db/migrations/20130131184954_new_initial_schema.rb by fixme

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    create_table :apps_routes do
      Integer :app_id, null: false
      foreign_key [:app_id], :apps, name: :fk_apps_routes_app_id

      Integer :route_id, null: false
Severity: Minor
Found in db/migrations/20130131184954_new_initial_schema.rb and 2 other locations - About 35 mins to fix
db/migrations/20130131184954_new_initial_schema.rb on lines 211..219
db/migrations/20130131184954_new_initial_schema.rb on lines 221..229

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 35.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    create_table :domains_spaces do
      Integer :space_id, null: false
      foreign_key [:space_id], :spaces, name: :fk_domains_spaces_space_id

      Integer :domain_id, null: false
Severity: Minor
Found in db/migrations/20130131184954_new_initial_schema.rb and 2 other locations - About 35 mins to fix
db/migrations/20130131184954_new_initial_schema.rb on lines 211..219
db/migrations/20130131184954_new_initial_schema.rb on lines 273..281

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 35.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    create_table :domains_organizations do
      Integer :domain_id, null: false
      foreign_key [:domain_id], :domains, name: :fk_domains_organizations_domain_id

      Integer :organization_id, null: false
Severity: Minor
Found in db/migrations/20130131184954_new_initial_schema.rb and 2 other locations - About 35 mins to fix
db/migrations/20130131184954_new_initial_schema.rb on lines 221..229
db/migrations/20130131184954_new_initial_schema.rb on lines 273..281

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 35.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    create_table :frameworks do
      VCAP::Migration.common(self)

      String :name,        null: false, case_insenstive: true
      String :description, null: false
Severity: Minor
Found in db/migrations/20130131184954_new_initial_schema.rb and 1 other location - About 30 mins to fix
db/migrations/20130131184954_new_initial_schema.rb on lines 116..124

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 32.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    create_table :runtimes do
      VCAP::Migration.common(self)

      String :name,        null: false, case_insensitive: true
      String :description, null: false
Severity: Minor
Found in db/migrations/20130131184954_new_initial_schema.rb and 1 other location - About 30 mins to fix
db/migrations/20130131184954_new_initial_schema.rb on lines 106..114

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 32.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status