Sign upLogin

cloudfoundry/cloud_controller_ng

View on GitHub
Star
lib/cloud_controller/deployment_updater/updater.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Class Updater has 25 methods (exceeds 20 allowed). Consider refactoring.
Open

    class Updater
      attr_reader :deployment, :logger

      def initialize(deployment, logger)
        @deployment = deployment
Severity: Minor
Found in lib/cloud_controller/deployment_updater/updater.rb - About 2 hrs to fix

    Method scale_deployment has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

          def scale_deployment
        deployment.db.transaction do
          app.lock!
          return unless deployment.lock!.state == DeploymentModel::DEPLOYING_STATE
    Severity: Minor
    Found in lib/cloud_controller/deployment_updater/updater.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status