Sign upLogin

cloudfoundry/cloud_controller_ng

View on GitHub
Star
lib/cloud_controller/diego/buildpack/task_action_builder.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method action has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def action
          download_droplet_action = ::Diego::Bbs::Models::DownloadAction.new(
            from: lifecycle_data[:droplet_uri],
            to: '.',
            cache_key: '',
Severity: Minor
Found in lib/cloud_controller/diego/buildpack/task_action_builder.rb - About 1 hr to fix

    Method initialize has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            def initialize(config, task, lifecycle_data, run_user, launcher_args, prefix)
    Severity: Minor
    Found in lib/cloud_controller/diego/buildpack/task_action_builder.rb - About 45 mins to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              def cached_dependencies
          return nil if @config.get(:diego, :enable_declarative_asset_downloads)

          [::Diego::Bbs::Models::CachedDependency.new(
            from: LifecycleBundleUriGenerator.uri(config.get(:diego, :lifecycle_bundles)[lifecycle_bundle_key]),
      Severity: Minor
      Found in lib/cloud_controller/diego/buildpack/task_action_builder.rb and 1 other location - About 35 mins to fix
      lib/cloud_controller/diego/cnb/staging_action_builder.rb on lines 14..23

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 35.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status