Sign upLogin

cloudfoundry/cloud_controller_ng

View on GitHub
Star
lib/cloud_controller/diego/task_recipe_builder.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method build_app_task has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def build_app_task(config, task)
        task_completion_callback = VCAP::CloudController::Diego::TaskCompletionCallbackGenerator.new(config).generate(task)
        app_volume_mounts        = VCAP::CloudController::Diego::Protocol::AppVolumeMounts.new(task.app).as_json
        task_action_builder      = LifecycleProtocol.protocol_for_type(task.droplet.lifecycle_type).task_action_builder(config, task)
Severity: Minor
Found in lib/cloud_controller/diego/task_recipe_builder.rb - About 1 hr to fix

    Method build_staging_task has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def build_staging_task(config, staging_details)
        lifecycle_type = staging_details.lifecycle.type
        action_builder = LifecycleProtocol.protocol_for_type(lifecycle_type).staging_action_builder(config, staging_details)

        ::Diego::Bbs::Models::TaskDefinition.new({
    Severity: Minor
    Found in lib/cloud_controller/diego/task_recipe_builder.rb - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status