Sign upLogin

cloudfoundry/cloud_controller_ng

View on GitHub
Star
lib/cloud_controller/rest_controller/secure_eager_loader.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Method build_eager_load_hash has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    def build_eager_load_hash(controller_class, model_class, default_visibility_filter, additional_visibility_filters, depth)
      associated_controller = controller_class

      # model_class cannot just be inferred from controller_class.model
      # because ServiceInstancesController can be used to present objects
Severity: Minor
Found in lib/cloud_controller/rest_controller/secure_eager_loader.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method build_eager_load_hash has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def build_eager_load_hash(controller_class, model_class, default_visibility_filter, additional_visibility_filters, depth)
      associated_controller = controller_class

      # model_class cannot just be inferred from controller_class.model
      # because ServiceInstancesController can be used to present objects
Severity: Minor
Found in lib/cloud_controller/rest_controller/secure_eager_loader.rb - About 1 hr to fix

    Method eager_load_dataset has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def eager_load_dataset(dataset, starting_controller_class, default_visibility_filter, additional_visibility_filters, depth)
    Severity: Minor
    Found in lib/cloud_controller/rest_controller/secure_eager_loader.rb - About 35 mins to fix

      Method build_eager_load_hash has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def build_eager_load_hash(controller_class, model_class, default_visibility_filter, additional_visibility_filters, depth)
      Severity: Minor
      Found in lib/cloud_controller/rest_controller/secure_eager_loader.rb - About 35 mins to fix

        There are no issues that match your filters.

        Category
        Status