Sign upLogin

cloudfoundry/cloud_controller_ng

View on GitHub
Star
lib/cloud_controller/transport_rule_validator.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method validate_port has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    def self.validate_port(port)
      return false if /[^\d\s\-,]/.match?(port)

      port_range = /\A\s*(\d+)\s*-\s*(\d+)\s*\z/.match(port)
      if port_range
Severity: Minor
Found in lib/cloud_controller/transport_rule_validator.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

        return false unless port_list.all? { |p| port_in_valid_range?(p.to_i) }
Severity: Major
Found in lib/cloud_controller/transport_rule_validator.rb - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

            return false unless port_list.all? { |p| /\A\s*\d+\s*\z/.match(p) }
    Severity: Major
    Found in lib/cloud_controller/transport_rule_validator.rb - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

              return true
      Severity: Major
      Found in lib/cloud_controller/transport_rule_validator.rb - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status