cloudfoundry/cloud_controller_ng

View on GitHub
lib/delayed_job/threaded_worker.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method threaded_start has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    def threaded_start
      self.class.lifecycle.run_callbacks(:execute, self) do
        loop do
          self.class.lifecycle.run_callbacks(:loop, self) do
            @realtime = Benchmark.realtime do
Severity: Minor
Found in lib/delayed_job/threaded_worker.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method start has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def start
      # add quit trap as in QuitTrap monkey patch
      trap('QUIT') do
        Thread.new { say 'Exiting...' }
        stop
Severity: Minor
Found in lib/delayed_job/threaded_worker.rb - About 1 hr to fix

    Method start has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        def start
          # add quit trap as in QuitTrap monkey patch
          trap('QUIT') do
            Thread.new { say 'Exiting...' }
            stop
    Severity: Minor
    Found in lib/delayed_job/threaded_worker.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status