Sign upLogin

cloudfoundry/cloud_controller_ng

View on GitHub
Star
lib/services/service_brokers/v2/catalog.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method validate_all_plan_ids_are_unique has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def validate_all_plan_ids_are_unique
      catalog_plans = {}
      services.each do |s|
        s.plans.each do |p|
          if catalog_plans[p.broker_provided_id]
Severity: Minor
Found in lib/services/service_brokers/v2/catalog.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method taken_names has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def taken_names(new_services_names)
      clashing_names = []
      clashing_services = service_broker.services_dataset.where(label: new_services_names)
      clashing_services.each do |old_service|
        new_service = services.detect { |ns| ns.name == old_service.name }
Severity: Minor
Found in lib/services/service_brokers/v2/catalog.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method compatible? has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def compatible?
      services.each do |service|
        if service.route_service? && route_services_disabled?
          incompatibility_errors.add("Service #{service.name} is declared to be a route service but support for route services is disabled.")
        end
Severity: Minor
Found in lib/services/service_brokers/v2/catalog.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status