Sign upLogin

cloudfoundry/cloud_controller_ng

View on GitHub
Star
lib/services/sso/dashboard_client_manager.rb

Summary

Maintainability
A
55 mins
Test Coverage

Method synchronize_clients_with_catalog has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    def synchronize_clients_with_catalog(catalog)
      requested_clients = catalog.services.map(&:dashboard_client).compact
      requested_client_ids = requested_clients.pluck('id')

      unless cc_configured_to_modify_uaa_clients?
Severity: Minor
Found in lib/services/sso/dashboard_client_manager.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status