cloudfoundry/cloud_controller_ng

View on GitHub
spec/unit/lib/cloud_controller/permissions_spec.rb

Summary

Maintainability
D
2 days
Test Coverage
require 'spec_helper'

module VCAP::CloudController
  RSpec.describe Permissions do
    let(:user) { User.make }
    let(:space) { Space.make(organization: org) }
    let(:org) { Organization.make }
    let(:space_guid) { space.guid }
    let(:org_guid) { org.guid }
    let(:permissions) { Permissions.new(user) }

    describe '#can_read_globally?' do
      context 'and user is an admin' do
        it 'returns true' do
          set_current_user(user, { admin: true })
          expect(permissions.can_read_globally?).to be true
        end
      end

      context 'and the user is a read only admin' do
        it 'returns true' do
          set_current_user(user, { admin_read_only: true })
          expect(permissions.can_read_globally?).to be true
        end
      end

      context 'and user is a global auditor' do
        it 'returns true' do
          set_current_user_as_global_auditor
          expect(permissions.can_read_globally?).to be true
        end
      end

      context 'and user is none of the above' do
        it 'returns false' do
          set_current_user(user)
          expect(permissions.can_read_globally?).to be false
        end
      end
    end

    describe '#can_update_build_state?' do
      context 'and user is an admin' do
        it 'returns true' do
          set_current_user(user, { admin: true })
          expect(permissions.can_update_build_state?).to be true
        end
      end

      context 'and the user is has the update_build_state scope' do
        it 'returns true' do
          set_current_user(user, { update_build_state: true })
          expect(permissions.can_update_build_state?).to be true
        end
      end

      context 'and the user is a read only admin' do
        it 'returns false' do
          set_current_user(user, { admin_read_only: true })
          expect(permissions.can_update_build_state?).to be false
        end
      end

      context 'and user is a global auditor' do
        it 'returns false' do
          set_current_user_as_global_auditor
          expect(permissions.can_update_build_state?).to be false
        end
      end

      context 'and user is none of the above' do
        it 'returns false' do
          set_current_user(user)
          expect(permissions.can_update_build_state?).to be false
        end
      end
    end

    describe '#can_write_globally?' do
      context 'and user is an admin' do
        it 'returns true' do
          set_current_user(user, { admin: true })
          expect(permissions.can_write_globally?).to be true
        end
      end

      context 'and the user is a read only admin' do
        it 'returns false' do
          set_current_user(user, { admin_read_only: true })
          expect(permissions.can_write_globally?).to be false
        end
      end

      context 'and user is a global auditor' do
        it 'returns false' do
          set_current_user_as_global_auditor
          expect(permissions.can_write_globally?).to be false
        end
      end

      context 'and user is none of the above' do
        it 'returns false' do
          set_current_user(user)
          expect(permissions.can_write_globally?).to be false
        end
      end
    end

    describe '#readable_org_guids' do
      it 'raises exception and does not SELECT all guids for admins' do
        user = set_current_user_as_admin
        subject = Permissions.new(user)
        expect do
          subject.readable_org_guids
        end.to raise_error('must not be called for users that can read globally')
      end

      it 'raises exception and does not SELECT all guids for read-only admins' do
        user = set_current_user_as_admin_read_only
        subject = Permissions.new(user)
        expect do
          subject.readable_org_guids
        end.to raise_error('must not be called for users that can read globally')
      end

      it 'raises exception and does not SELECT all guids for global auditors' do
        user = set_current_user_as_global_auditor
        subject = Permissions.new(user)
        expect do
          subject.readable_org_guids
        end.to raise_error('must not be called for users that can read globally')
      end

      it 'returns org guids from membership via subquery' do
        guid1, guid2 = double
        org_guid_records = [guid1, guid2]
        membership = instance_double(Membership)
        subquery = instance_double(Sequel::Dataset)
        expect(Membership).to receive(:new).with(user).and_return(membership)
        expect(membership).to receive(:authorized_org_guids_subquery).with(Permissions::ROLES_FOR_ORG_READING).and_return(subquery)
        expect(subquery).to receive(:select_map).and_return(org_guid_records)
        expect(permissions.readable_org_guids).to eq([guid1, guid2])
      end
    end

    describe '#readable_org_guids_query' do
      it 'returns subquery from membership' do
        membership = instance_double(Membership)
        subquery = instance_double(Sequel::Dataset)
        expect(Membership).to receive(:new).with(user).and_return(membership)
        expect(membership).to receive(:authorized_org_guids_subquery).with(Permissions::ROLES_FOR_ORG_READING).and_return(subquery)
        expect(permissions.readable_org_guids_query).to be(subquery)
      end
    end

    describe '#readable_orgs_query' do
      it 'returns subquery from membership' do
        membership = instance_double(Membership)
        subquery = instance_double(Sequel::Dataset)
        expect(Membership).to receive(:new).with(user).and_return(membership)
        expect(membership).to receive(:authorized_orgs_subquery).with(Permissions::ROLES_FOR_ORG_READING).and_return(subquery)
        expect(permissions.readable_orgs_query).to be(subquery)
      end
    end

    describe '#readable_org_guids_for_domains_query' do
      context 'when user has valid membership' do
        let(:membership) { instance_double(Membership) }
        let(:space_guid) { double(:space_guid) }
        let(:subquery) { instance_double(Sequel::Dataset) }
        let(:first_org_guid) { double(:first_org_guid) }
        let(:second_org_guid) { double(:second_org_guid) }

        before do
          allow(membership).to receive(:authorized_org_guids_subquery).
            with(Permissions::ORG_ROLES_FOR_READING_DOMAINS_FROM_ORGS + Permissions::SPACE_ROLES).
            and_return(subquery)
          allow(Membership).to receive(:new).with(user).and_return(membership)
        end

        it 'combines readable orgs for both org-scoped and space-scoped roles' do
          allow(membership).to receive(:authorized_space_guids).
            with(Permissions::SPACE_ROLES).
            and_return([space_guid])

          expect(permissions.readable_org_guids_for_domains_query).
            to be(subquery)
        end
      end
    end

    describe '#can_read_from_org?' do
      context 'user has no membership' do
        context 'and user is an admin' do
          it 'returns true' do
            set_current_user(user, { admin: true })
            expect(permissions.can_read_from_org?(org.id)).to be true
          end
        end

        context 'and user is a read only admin' do
          it 'returns true' do
            set_current_user(user, { admin_read_only: true })
            expect(permissions.can_read_from_org?(org.id)).to be true
          end
        end

        context 'and user is a global auditor' do
          it 'returns true' do
            set_current_user_as_global_auditor
            expect(permissions.can_read_from_org?(org.id)).to be true
          end
        end

        context 'and user is not an admin' do
          it 'returns false' do
            set_current_user(user)
            expect(permissions.can_read_from_org?(org.id)).to be false
          end
        end
      end

      context 'user has valid membership' do
        it 'returns true for org user' do
          org.add_user(user)
          expect(permissions.can_read_from_org?(org.id)).to be true
        end

        it 'returns true for org auditor' do
          org.add_auditor(user)
          expect(permissions.can_read_from_org?(org.id)).to be true
        end

        it 'returns true for org manager' do
          org.add_manager(user)
          expect(permissions.can_read_from_org?(org.id)).to be true
        end

        it 'returns true for org billing manager' do
          org.add_billing_manager(user)
          expect(permissions.can_read_from_org?(org.id)).to be true
        end
      end
    end

    describe '#can_write_to_active_org?' do
      context 'user has no membership' do
        context 'and user is an admin' do
          it 'returns true' do
            set_current_user(user, { admin: true })
            expect(permissions.can_read_from_org?(org.id)).to be true
          end
        end

        context 'and user is a read only admin' do
          it 'returns false' do
            set_current_user(user, { admin_read_only: true })
            expect(permissions.can_write_to_active_org?(org.id)).to be false
          end
        end

        context 'and user is a global auditor' do
          it 'returns false' do
            set_current_user_as_global_auditor
            expect(permissions.can_write_to_active_org?(org.id)).to be false
          end
        end

        context 'and user is not an admin' do
          it 'returns false' do
            set_current_user(user)
            expect(permissions.can_write_to_active_org?(org.id)).to be false
          end
        end
      end

      context 'user has valid membership' do
        it 'returns false for org user' do
          org.add_user(user)
          expect(permissions.can_write_to_active_org?(org.id)).to be false
        end

        it 'returns false for org auditor' do
          org.add_auditor(user)
          expect(permissions.can_write_to_active_org?(org.id)).to be false
        end

        it 'returns true for org manager' do
          org.add_manager(user)
          expect(permissions.can_write_to_active_org?(org.id)).to be true
        end

        it 'returns false for org billing manager' do
          org.add_billing_manager(user)
          expect(permissions.can_write_to_active_org?(org.id)).to be false
        end
      end
    end

    describe '#is_org_active?' do
      it 'returns true' do
        expect(permissions.is_org_active?(org.id)).to be true
      end

      context 'org is suspended' do
        before do
          org.update(status: Organization::SUSPENDED)
        end

        it 'returns false' do
          set_current_user(user)
          expect(permissions.is_org_active?(org.id)).to be false
        end

        it 'returns true for an admin' do
          set_current_user(user, { admin: true })
          expect(permissions.is_org_active?(org.id)).to be true
        end
      end
    end

    describe '#is_space_active?' do
      it 'returns true' do
        expect(permissions.is_space_active?(space.id)).to be true
      end

      context 'org is suspended' do
        before do
          space.organization.update(status: Organization::SUSPENDED)
        end

        it 'returns false' do
          set_current_user(user)
          expect(permissions.is_space_active?(space.id)).to be false
        end

        it 'returns true for an admin' do
          set_current_user(user, { admin: true })
          expect(permissions.is_space_active?(space.id)).to be true
        end
      end
    end

    describe '#readable_space_guids' do
      it 'raises exception and does not SELECT all guids for admins' do
        user = set_current_user_as_admin
        subject = Permissions.new(user)
        expect do
          subject.readable_space_guids
        end.to raise_error('must not be called for users that can read globally')
      end

      it 'raises exception and does not SELECT all guids for read-only admins' do
        user = set_current_user_as_admin_read_only
        subject = Permissions.new(user)
        expect do
          subject.readable_space_guids
        end.to raise_error('must not be called for users that can read globally')
      end

      it 'raises exception and does not SELECT all guids for global auditors' do
        user = set_current_user_as_global_auditor
        subject = Permissions.new(user)
        expect do
          subject.readable_space_guids
        end.to raise_error('must not be called for users that can read globally')
      end

      it 'returns space guids from membership via subquery' do
        guid1, guid2 = double
        space_guid_records = [guid1, guid2]
        membership = instance_double(Membership)
        subquery = instance_double(Sequel::Dataset)
        expect(Membership).to receive(:new).with(user).and_return(membership)
        expect(membership).to receive(:authorized_space_guids_subquery).with(Permissions::ROLES_FOR_SPACE_READING).and_return(subquery)
        expect(subquery).to receive(:select_map).and_return(space_guid_records)
        expect(permissions.readable_space_guids).to eq([guid1, guid2])
      end
    end

    describe '#readables_space_query' do
      it 'returns subquery from membership' do
        membership = instance_double(Membership)
        subquery = instance_double(Sequel::Dataset)
        expect(Membership).to receive(:new).with(user).and_return(membership)
        expect(membership).to receive(:authorized_spaces_subquery).with(Permissions::ROLES_FOR_SPACE_READING).and_return(subquery)
        expect(permissions.readable_spaces_query).to be(subquery)
      end
    end

    describe '#readables_space_guids_query' do
      it 'returns subquery from membership' do
        membership = instance_double(Membership)
        subquery = instance_double(Sequel::Dataset)
        expect(Membership).to receive(:new).with(user).and_return(membership)
        expect(membership).to receive(:authorized_space_guids_subquery).with(Permissions::ROLES_FOR_SPACE_READING).and_return(subquery)
        expect(permissions.readable_space_guids_query).to be(subquery)
      end
    end

    describe '#can_read_from_space?' do
      context 'user has no membership' do
        context 'and user is an admin' do
          it 'returns true' do
            set_current_user(user, { admin: true })
            expect(permissions.can_read_from_space?(space.id, org.id)).to be true
          end
        end

        context 'and the user is a read only admin' do
          it 'returns true' do
            set_current_user(user, { admin_read_only: true })
            expect(permissions.can_read_from_space?(space.id, org.id)).to be true
          end
        end

        context 'and user is a global auditor' do
          it 'returns true' do
            set_current_user_as_global_auditor
            expect(permissions.can_read_from_space?(space.id, org.id)).to be true
          end
        end

        context 'and user is not an admin' do
          it 'returns false' do
            set_current_user(user)
            expect(permissions.can_read_from_space?(space.id, org.id)).to be false
          end
        end
      end

      context 'user has valid membership' do
        it 'returns true for space developer' do
          org.add_user(user)
          space.add_developer(user)
          expect(permissions.can_read_from_space?(space.id, org.id)).to be true
        end

        it 'returns true for space manager' do
          org.add_user(user)
          space.add_manager(user)
          expect(permissions.can_read_from_space?(space.id, org.id)).to be true
        end

        it 'returns true for space auditor' do
          org.add_user(user)
          space.add_auditor(user)
          expect(permissions.can_read_from_space?(space.id, org.id)).to be true
        end

        it 'returns true for org manager' do
          org.add_manager(user)
          expect(permissions.can_read_from_space?(space.id, org.id)).to be true
        end
      end
    end

    describe '#can_delete_buildpack_cache?' do
      context 'user has no membership' do
        context 'and user is an admin' do
          it 'returns true' do
            set_current_user(user, { admin: true })
            expect(permissions.can_delete_buildpack_cache?(space.id)).to be true
          end
        end

        context 'and the user is a read only admin' do
          it 'returns false' do
            set_current_user(user, { admin_read_only: true })
            expect(permissions.can_delete_buildpack_cache?(space.id)).to be false
          end
        end

        context 'and user is a global auditor' do
          it 'returns false' do
            set_current_user_as_global_auditor
            expect(permissions.can_delete_buildpack_cache?(space.id)).to be false
          end
        end

        context 'and user is not an admin' do
          it 'returns false' do
            set_current_user(user)
            expect(permissions.can_delete_buildpack_cache?(space.id)).to be false
          end
        end
      end

      context 'user has valid membership' do
        it 'returns true for space supporter' do
          org.add_user(user)
          space.add_supporter(user)
          expect(permissions.can_delete_buildpack_cache?(space.id)).to be true
        end

        it 'returns true for space developer' do
          org.add_user(user)
          space.add_developer(user)
          expect(permissions.can_delete_buildpack_cache?(space.id)).to be true
        end

        it 'returns false for space manager' do
          org.add_user(user)
          space.add_manager(user)
          expect(permissions.can_delete_buildpack_cache?(space.id)).to be false
        end

        it 'returns false for space auditor' do
          org.add_user(user)
          space.add_auditor(user)
          expect(permissions.can_delete_buildpack_cache?(space.id)).to be false
        end

        it 'returns false for org manager' do
          org.add_manager(user)
          expect(permissions.can_delete_buildpack_cache?(space.id)).to be false
        end
      end
    end

    describe '#can_read_secrets_in_space?' do
      context 'user has no membership' do
        context 'and user is an admin' do
          it 'returns true' do
            set_current_user_as_admin
            expect(permissions.can_read_secrets_in_space?(space.id, org.id)).to be true
          end
        end

        context 'and user is admin_read_only' do
          it 'returns true' do
            set_current_user_as_admin_read_only
            expect(permissions.can_read_secrets_in_space?(space.id, org.id)).to be true
          end
        end

        context 'and user is global auditor' do
          it 'return false' do
            set_current_user_as_global_auditor
            expect(permissions.can_read_secrets_in_space?(space.id, org.id)).to be false
          end
        end

        context 'and user is not an admin' do
          it 'return false' do
            set_current_user(user)
            expect(permissions.can_read_secrets_in_space?(space.id, org.id)).to be false
          end
        end
      end

      context 'user has valid membership' do
        it 'returns true for space developer' do
          org.add_user(user)
          space.add_developer(user)
          expect(permissions.can_read_secrets_in_space?(space.id, org.id)).to be true
        end

        it 'returns false for space manager' do
          org.add_user(user)
          space.add_manager(user)
          expect(permissions.can_read_secrets_in_space?(space.id, org.id)).to be false
        end

        it 'returns false for space auditor' do
          org.add_user(user)
          space.add_auditor(user)
          expect(permissions.can_read_secrets_in_space?(space.id, org.id)).to be false
        end

        it 'returns false for org manager' do
          org.add_manager(user)
          expect(permissions.can_read_secrets_in_space?(space.id, org.id)).to be false
        end
      end
    end

    describe '#readable_space_scoped_spaces' do
      it 'calls all on subquery' do
        space_records = double
        subquery = instance_double(Sequel::Dataset)
        expect(subquery).to receive(:all).and_return(space_records)
        expect(permissions).to receive(:readable_space_scoped_spaces_query).and_return(subquery)
        expect(permissions.readable_space_scoped_spaces).to be(space_records)
      end
    end

    describe '#readable_space_scoped_spaces_query' do
      it 'returns subquery from membership' do
        membership = instance_double(Membership)
        subquery = instance_double(Sequel::Dataset)
        expect(Membership).to receive(:new).with(user).and_return(membership)
        expect(membership).to receive(:authorized_spaces_subquery).with(Permissions::SPACE_ROLES).and_return(subquery)
        expect(permissions.readable_space_scoped_spaces_query).to be(subquery)
      end
    end

    describe '#can_write_to_active_space?' do
      context 'user has no membership' do
        context 'and user is an admin' do
          it 'returns true' do
            set_current_user(user, { admin: true })
            expect(permissions.can_write_to_active_space?(space.id)).to be true
          end
        end

        context 'and user is admin_read_only' do
          it 'return false' do
            set_current_user_as_admin_read_only
            expect(permissions.can_write_to_active_space?(space.id)).to be false
          end
        end

        context 'and user is global auditor' do
          it 'return false' do
            set_current_user_as_global_auditor
            expect(permissions.can_write_to_active_space?(space.id)).to be false
          end
        end

        context 'and user is not an admin' do
          it 'return false' do
            set_current_user(user)
            expect(permissions.can_write_to_active_space?(space.id)).to be false
          end
        end
      end

      context 'user has valid membership' do
        it 'returns true for space developer' do
          org.add_user(user)
          space.add_developer(user)
          expect(permissions.can_write_to_active_space?(space.id)).to be true
        end

        it 'returns false for space manager' do
          org.add_user(user)
          space.add_manager(user)
          expect(permissions.can_write_to_active_space?(space.id)).to be false
        end

        it 'returns false for space auditor' do
          org.add_user(user)
          space.add_auditor(user)
          expect(permissions.can_write_to_active_space?(space.id)).to be false
        end

        it 'returns false for org manager' do
          org.add_manager(user)
          expect(permissions.can_write_to_active_space?(space.id)).to be false
        end
      end
    end

    describe '#can_manage_apps_in_active_space?' do
      context 'user has no membership' do
        context 'and user is an admin' do
          it 'returns true' do
            set_current_user(user, { admin: true })
            expect(permissions.can_manage_apps_in_active_space?(space.id)).to be true
          end
        end

        context 'and user is admin_read_only' do
          it 'return false' do
            set_current_user_as_admin_read_only
            expect(permissions.can_manage_apps_in_active_space?(space.id)).to be false
          end
        end

        context 'and user is global auditor' do
          it 'return false' do
            set_current_user_as_global_auditor
            expect(permissions.can_manage_apps_in_active_space?(space.id)).to be false
          end
        end

        context 'and user is not an admin' do
          it 'return false' do
            set_current_user(user)
            expect(permissions.can_manage_apps_in_active_space?(space.id)).to be false
          end
        end
      end

      context 'user has valid membership' do
        it 'returns true for space developer' do
          org.add_user(user)
          space.add_developer(user)
          expect(permissions.can_manage_apps_in_active_space?(space.id)).to be true
        end

        it 'returns false for space manager' do
          org.add_user(user)
          space.add_manager(user)
          expect(permissions.can_manage_apps_in_active_space?(space.id)).to be false
        end

        it 'returns false for space auditor' do
          org.add_user(user)
          space.add_auditor(user)
          expect(permissions.can_manage_apps_in_active_space?(space.id)).to be false
        end

        it 'returns false for org manager' do
          org.add_manager(user)
          expect(permissions.can_manage_apps_in_active_space?(space.id)).to be false
        end

        it 'returns true for space supporter' do
          org.add_user(user)
          space.add_supporter(user)
          expect(permissions.can_manage_apps_in_active_space?(space.id)).to be true
        end
      end
    end

    describe '#can_update_active_space?' do
      context 'user has no membership' do
        context 'and user is an admin' do
          it 'returns true' do
            set_current_user(user, { admin: true })
            expect(permissions.can_update_active_space?(space.id, org.id)).to be true
          end
        end

        context 'and user is admin_read_only' do
          it 'return false' do
            set_current_user_as_admin_read_only
            expect(permissions.can_update_active_space?(space.id, org.id)).to be false
          end
        end

        context 'and user is global auditor' do
          it 'return false' do
            set_current_user_as_global_auditor
            expect(permissions.can_update_active_space?(space.id, org.id)).to be false
          end
        end

        context 'and user is not an admin' do
          it 'return false' do
            set_current_user(user)
            expect(permissions.can_update_active_space?(space.id, org.id)).to be false
          end
        end
      end

      context 'user has valid membership' do
        it 'returns true for space manager' do
          org.add_user(user)
          space.add_manager(user)
          expect(permissions.can_update_active_space?(space.id, org.id)).to be true
        end

        it 'returns false for space developer' do
          org.add_user(user)
          space.add_developer(user)
          expect(permissions.can_update_active_space?(space.id, org.id)).to be false
        end

        it 'returns false for space auditor' do
          org.add_user(user)
          space.add_auditor(user)
          expect(permissions.can_update_active_space?(space.id, org.id)).to be false
        end

        it 'returns true for org manager' do
          org.add_manager(user)
          expect(permissions.can_update_active_space?(space.id, org.id)).to be true
        end
      end
    end

    describe '#readable_event_dataset' do
      let!(:unscoped_event) { Event.make(actee: 'dir/key', type: 'blob.remove_orphan', organization_guid: '') }
      let!(:org_scoped_event) { Event.make(created_at: Time.now + 100, type: 'audit.organization.create', actee: org_guid, organization_guid: org_guid) }
      let!(:space_scoped_event) { Event.make(space_guid: space_guid, actee: space_guid, type: 'audit.app.restart') }

      it 'returns all events for admins' do
        user = set_current_user_as_admin
        event_guids = Permissions.new(user).readable_event_dataset.map(&:guid)

        expect(event_guids).to contain_exactly(unscoped_event.guid, org_scoped_event.guid, space_scoped_event.guid)
      end

      it 'returns all events for read-only admins' do
        user = set_current_user_as_admin_read_only
        event_guids = Permissions.new(user).readable_event_dataset.map(&:guid)

        expect(event_guids).to contain_exactly(unscoped_event.guid, org_scoped_event.guid, space_scoped_event.guid)
      end

      it 'returns all events for global auditors' do
        user = set_current_user_as_global_auditor
        event_guids = Permissions.new(user).readable_event_dataset.map(&:guid)

        expect(event_guids).to contain_exactly(unscoped_event.guid, org_scoped_event.guid, space_scoped_event.guid)
      end

      it 'returns event datasets from space membership' do
        membership = instance_double(Membership)
        expect(Membership).to receive(:new).with(user).and_return(membership)
        expect(membership).to receive(:authorized_space_guids).
          with(Permissions::SPACE_ROLES_FOR_EVENTS).
          and_return([space_guid])
        expect(membership).to receive(:authorized_org_guids).with(Membership::ORG_AUDITOR).and_return([])
        event_guids = Permissions.new(user).readable_event_dataset.map(&:guid)

        expect(event_guids).to contain_exactly(space_scoped_event.guid)
      end

      it 'returns event datasets from org membership' do
        membership = instance_double(Membership)
        expect(Membership).to receive(:new).with(user).and_return(membership)
        expect(membership).to receive(:authorized_space_guids).
          with(Permissions::SPACE_ROLES_FOR_EVENTS).
          and_return([])
        expect(membership).to receive(:authorized_org_guids).with(Membership::ORG_AUDITOR).and_return(org_guid)
        event_guids = Permissions.new(user).readable_event_dataset.map(&:guid)

        expect(event_guids).to contain_exactly(org_scoped_event.guid)
      end
    end

    describe '#can_read_from_isolation_segment?' do
      let(:isolation_segment) { IsolationSegmentModel.make }
      let(:assigner) { IsolationSegmentAssign.new }

      before do
        assigner.assign(isolation_segment, [org])
      end

      context 'user has no membership' do
        context 'and user is an admin' do
          it 'returns true' do
            set_current_user_as_admin
            expect(permissions.can_read_from_isolation_segment?(isolation_segment)).to be true
          end
        end

        context 'and user is admin_read_only' do
          it 'returns true' do
            set_current_user_as_admin_read_only
            expect(permissions.can_read_from_isolation_segment?(isolation_segment)).to be true
          end
        end

        context 'and user is global auditor' do
          it 'return true' do
            set_current_user_as_global_auditor
            expect(permissions.can_read_from_isolation_segment?(isolation_segment)).to be true
          end
        end

        context 'and user is not an admin' do
          it 'return false' do
            set_current_user(user)
            expect(permissions.can_read_from_isolation_segment?(isolation_segment)).to be false
          end
        end
      end

      context 'user has valid membership' do
        it 'returns true for space developer' do
          org.add_user(user)
          space.add_developer(user)
          expect(permissions.can_read_from_isolation_segment?(isolation_segment)).to be true
        end

        it 'returns true for space manager' do
          org.add_user(user)
          space.add_manager(user)
          expect(permissions.can_read_from_isolation_segment?(isolation_segment)).to be true
        end

        it 'returns true for space auditor' do
          org.add_user(user)
          space.add_auditor(user)
          expect(permissions.can_read_from_isolation_segment?(isolation_segment)).to be true
        end

        it 'returns true for org manager' do
          org.add_manager(user)
          expect(permissions.can_read_from_isolation_segment?(isolation_segment)).to be true
        end

        it 'returns true for org auditor' do
          org.add_auditor(user)
          expect(permissions.can_read_from_isolation_segment?(isolation_segment)).to be true
        end

        it 'returns true for org user' do
          org.add_user(user)
          expect(permissions.can_read_from_isolation_segment?(isolation_segment)).to be true
        end

        it 'returns true for org billing manager' do
          org.add_billing_manager(user)
          expect(permissions.can_read_from_isolation_segment?(isolation_segment)).to be true
        end
      end
    end

    describe '#readable_route_dataset' do
      it 'returns all the routes for admins' do
        user = set_current_user_as_admin
        subject = Permissions.new(user)

        org1 = Organization.make
        space1 = Space.make(organization: org1)
        route1 = Route.make(space: space1)
        route2 = Route.make(space: space1)
        org2 = Organization.make
        space2 = Space.make(organization: org2)
        route3 = Route.make(space: space2)

        dataset = subject.readable_route_dataset

        expect(dataset.first(guid: route1.guid)).to be_present
        expect(dataset.first(guid: route2.guid)).to be_present
        expect(dataset.first(guid: route3.guid)).to be_present
      end

      it 'returns routes where the user has an appropriate org membership' do
        manager_org = Organization.make
        manager_space = Space.make(organization: manager_org)
        manager_route = Route.make(space: manager_space)
        manager_org.add_manager(user)

        auditor_org = Organization.make
        auditor_space = Space.make(organization: auditor_org)
        auditor_route = Route.make(space: auditor_space)
        auditor_org.add_auditor(user)

        billing_manager_org = Organization.make
        billing_manager_space = Space.make(organization: billing_manager_org)
        billing_manager_route = Route.make(space: billing_manager_space)
        billing_manager_org.add_billing_manager(user)

        member_org = Organization.make
        member_space = Space.make(organization: member_org)
        member_route = Route.make(space: member_space)
        member_org.add_user(user)

        dataset = permissions.readable_route_dataset

        expect(dataset.first(guid: manager_route.guid)).to be_present
        expect(dataset.first(guid: auditor_route.guid)).to be_present
        expect(dataset.first(guid: billing_manager_route.guid)).to be_nil
        expect(dataset.first(guid: member_route.guid)).to be_nil
      end
    end

    describe '#can_read_route?' do
      it 'returns true if user is an admin' do
        set_current_user(user, { admin: true })
        expect(permissions.can_read_route?(space.id)).to be true
      end

      it 'returns true if user is a read-only admin' do
        set_current_user(user, { admin_read_only: true })
        expect(permissions.can_read_route?(space.id)).to be true
      end

      it 'returns true if user is a global auditor' do
        set_current_user_as_global_auditor
        expect(permissions.can_read_route?(space.id)).to be true
      end

      it 'returns true for space developer' do
        org.add_user(user)
        space.add_developer(user)

        expect(permissions.can_read_route?(space.id)).to be true
      end

      it 'returns true for space manager' do
        org.add_user(user)
        space.add_manager(user)

        expect(permissions.can_read_route?(space.id)).to be true
      end

      it 'returns true for space auditor' do
        org.add_user(user)
        space.add_auditor(user)

        expect(permissions.can_read_route?(space.id)).to be true
      end

      it 'returns true for org manager' do
        org.add_user(user)
        org.add_manager(user)

        expect(permissions.can_read_route?(space.id)).to be true
      end

      it 'returns true for org auditor' do
        org.add_user(user)
        org.add_auditor(user)

        expect(permissions.can_read_route?(space.id)).to be true
      end

      it 'returns true for space supporter' do
        org.add_user(user)
        space.add_supporter(user)

        expect(permissions.can_read_route?(space.id)).to be true
      end

      it 'returns false for org billing manager' do
        org.add_user(user)
        org.add_billing_manager(user)

        expect(permissions.can_read_route?(space.id)).to be false
      end

      it 'returns false for regular org user' do
        org.add_user(user)

        expect(permissions.can_read_route?(space.id)).to be false
      end

      it 'returns false for other user' do
        expect(permissions.can_read_route?(space.id)).to be false
      end
    end

    describe '#can_read_route?' do
      it 'returns true if user is an admin' do
        set_current_user(user, { admin: true })
        expect(permissions.can_read_route?(space.id)).to be true
      end

      it 'returns true if user is a read-only admin' do
        set_current_user(user, { admin_read_only: true })
        expect(permissions.can_read_route?(space.id)).to be true
      end

      it 'returns true if user is a global auditor' do
        set_current_user_as_global_auditor
        expect(permissions.can_read_route?(space.id)).to be true
      end

      it 'returns true for space developer' do
        org.add_user(user)
        space.add_developer(user)

        expect(permissions.can_read_route?(space.id)).to be true
      end

      it 'returns true for space manager' do
        org.add_user(user)
        space.add_manager(user)

        expect(permissions.can_read_route?(space.id)).to be true
      end

      it 'returns true for space auditor' do
        org.add_user(user)
        space.add_auditor(user)

        expect(permissions.can_read_route?(space.id)).to be true
      end

      it 'returns true for space supporter' do
        org.add_user(user)
        space.add_supporter(user)

        expect(permissions.can_read_route?(space.id)).to be true
      end

      it 'returns true for org manager' do
        org.add_user(user)
        org.add_manager(user)

        expect(permissions.can_read_route?(space.id)).to be true
      end

      it 'returns true for org auditor' do
        org.add_user(user)
        org.add_auditor(user)

        expect(permissions.can_read_route?(space.id)).to be true
      end

      it 'returns false for org billing manager' do
        org.add_user(user)
        org.add_billing_manager(user)

        expect(permissions.can_read_route?(space.id)).to be false
      end

      it 'returns false for regular org user' do
        org.add_user(user)

        expect(permissions.can_read_route?(space.id)).to be false
      end

      it 'returns false for other user' do
        expect(permissions.can_read_route?(space.id)).to be false
      end
    end

    describe '#readable_app_guids' do
      it 'returns all the app guids for admins' do
        user = set_current_user_as_admin
        subject = Permissions.new(user)

        org1 = Organization.make
        space1 = Space.make(organization: org1)
        app1 = AppModel.make(space: space1)
        org2 = Organization.make
        space2 = Space.make(organization: org2)
        app2 = AppModel.make(space: space2)

        app_guids = subject.readable_app_guids

        expect(app_guids).to include(app1.guid)
        expect(app_guids).to include(app2.guid)
      end

      it 'returns all the app guids for read-only admins' do
        user = set_current_user_as_admin_read_only
        subject = Permissions.new(user)

        org1 = Organization.make
        space1 = Space.make(organization: org1)
        app1 = AppModel.make(space: space1)
        org2 = Organization.make
        space2 = Space.make(organization: org2)
        app2 = AppModel.make(space: space2)

        app_guids = subject.readable_app_guids

        expect(app_guids).to include(app1.guid)
        expect(app_guids).to include(app2.guid)
      end

      it 'returns all the app guids for global auditors' do
        user = set_current_user_as_global_auditor
        subject = Permissions.new(user)

        org1 = Organization.make
        space1 = Space.make(organization: org1)
        app1 = AppModel.make(space: space1)
        org2 = Organization.make
        space2 = Space.make(organization: org2)
        app2 = AppModel.make(space: space2)

        app_guids = subject.readable_app_guids

        expect(app_guids).to include(app1.guid)
        expect(app_guids).to include(app2.guid)
      end

      it 'returns app guids where the user has an appropriate org membership' do
        manager_org = Organization.make
        manager_space = Space.make(organization: manager_org)
        manager_app = AppModel.make(space: manager_space)
        manager_org.add_manager(user)

        auditor_org = Organization.make
        auditor_space = Space.make(organization: auditor_org)
        auditor_app = AppModel.make(space: auditor_space)
        auditor_org.add_auditor(user)

        billing_manager_org = Organization.make
        billing_manager_space = Space.make(organization: billing_manager_org)
        billing_manager_app = AppModel.make(space: billing_manager_space)
        billing_manager_org.add_billing_manager(user)

        member_org = Organization.make
        member_space = Space.make(organization: member_org)
        member_app = AppModel.make(space: member_space)
        member_org.add_user(user)

        app_guids = permissions.readable_app_guids

        expect(app_guids).to contain_exactly(manager_app.guid)
        expect(app_guids).not_to include(auditor_app.guid)
        expect(app_guids).not_to include(billing_manager_app.guid)
        expect(app_guids).not_to include(member_app.guid)
      end

      it 'returns app guids where the user has an appropriate space membership' do
        org = Organization.make
        org.add_user(user)

        developer_space = Space.make(organization: org)
        developer_app = AppModel.make(space: developer_space)
        developer_space.add_developer(user)

        manager_space = Space.make(organization: org)
        manager_app = AppModel.make(space: manager_space)
        manager_space.add_manager(user)

        auditor_space = Space.make(organization: org)
        auditor_app = AppModel.make(space: auditor_space)
        auditor_space.add_auditor(user)

        app_guids = permissions.readable_app_guids

        expect(app_guids).to contain_exactly(developer_app.guid, manager_app.guid, auditor_app.guid)
      end
    end

    describe '#readable_space_quota_guids' do
      let(:org1) { Organization.make }
      let(:org2) { Organization.make }
      let(:squota1) { SpaceQuotaDefinition.make(organization: org1, guid: 'q1') }
      let!(:squota2) { SpaceQuotaDefinition.make(organization: org1, guid: 'q2') }
      let(:squota3) { SpaceQuotaDefinition.make(organization: org2, guid: 'q3') }
      let!(:space1) { Space.make(organization: org1, space_quota_definition: squota1) }
      let!(:space2) { Space.make(organization: org2, space_quota_definition: squota3) }

      it 'returns all the space quota guids for any global read role' do
        global_roles = [set_current_user_as_admin, set_current_user_as_global_auditor, set_current_user_as_admin_read_only]
        global_roles.each do |user|
          subject = Permissions.new(user)

          space_quota_guids = subject.readable_space_quota_guids

          expect(space_quota_guids).to include(squota1.guid)
          expect(space_quota_guids).to include(squota2.guid)
          expect(space_quota_guids).to include(squota3.guid)
        end
      end

      it 'returns space quota guids when the user is an org_manager' do
        user = set_current_user_as_role(role: 'org_manager', org: org1)
        subject = Permissions.new(user)

        space_quota_guids = subject.readable_space_quota_guids

        expect(space_quota_guids).to contain_exactly(squota1.guid, squota2.guid)
        expect(space_quota_guids).not_to include(squota3.guid)
      end

      it 'does not return any space quotas when the user has a non org manager org role' do
        org_roles = [
          set_current_user_as_role(role: 'org_billing_manager', org: org2),
          set_current_user_as_role(role: 'org_user', org: org2),
          set_current_user_as_role(role: 'org_auditor', org: org2)
        ]
        org_roles.each do |user|
          subject = Permissions.new(user)

          space_quota_guids = subject.readable_space_quota_guids
          expect(space_quota_guids).not_to include(squota1.guid)
          expect(space_quota_guids).not_to include(squota2.guid)
          expect(space_quota_guids).not_to include(squota3.guid)
        end
      end

      it 'returns space quotas when the user has an appropriate space membership' do
        space_roles = [
          set_current_user_as_role(role: 'space_manager', org: org2, space: space2),
          set_current_user_as_role(role: 'space_developer', org: org2, space: space2),
          set_current_user_as_role(role: 'space_auditor', org: org2, space: space2)
        ]

        space_roles.each do |user|
          subject = Permissions.new(user)

          space_quota_guids = subject.readable_space_quota_guids
          expect(space_quota_guids).to contain_exactly(squota3.guid)
          expect(space_quota_guids).not_to include(squota1.guid)
          expect(space_quota_guids).not_to include(squota2.guid)
        end
      end
    end
  end
end