cloudfoundry/cloud_controller_ng

View on GitHub
spec/unit/messages/manifest_process_update_message_spec.rb

Summary

Maintainability
A
3 hrs
Test Coverage
require 'spec_helper'
require 'messages/manifest_process_update_message'

module VCAP::CloudController
  RSpec.describe ManifestProcessUpdateMessage do
    let(:message) { ManifestProcessUpdateMessage.new(body) }
    let(:body) { {} }

    describe 'validations' do
      let(:message) { ManifestProcessUpdateMessage.new(params) }

      context 'when unexpected keys are requested' do
        let(:params) { { unexpected: 'foo', extra: 'bar', ports: [8181] } }

        it 'is not valid' do
          expect(message).not_to be_valid
          expect(message.errors.full_messages[0]).to include("Unknown field(s): 'unexpected', 'extra', 'ports'")
        end
      end

      context 'when no keys are requested' do
        let(:params) { {} }

        it 'is valid' do
          expect(message).to be_valid
        end
      end

      describe 'command' do
        context 'when command is not a string' do
          let(:params) { { command: 32.77 } }

          it 'is not valid' do
            expect(message).not_to be_valid
            expect(message.errors[:command]).to include('must be a string')
          end
        end

        context 'when command is nil' do
          let(:params) { { command: nil } }

          it 'is not valid' do
            expect(message).not_to be_valid
            expect(message.errors[:command]).to include('must be a string')
          end
        end

        context 'when command is too long' do
          let(:params) { { command: 'a' * 5098 } }

          it 'is not valid' do
            expect(message).not_to be_valid
            expect(message.errors[:command]).to include('must be between 1 and 4096 characters')
          end
        end

        context 'when command is empty' do
          let(:params) { { command: '' } }

          it 'is not valid' do
            expect(message).not_to be_valid
            expect(message.errors[:command]).to include('must be between 1 and 4096 characters')
          end
        end
      end

      describe 'health_check_type' do
        context 'when health_check type is http' do
          let(:params) { { health_check_type: 'http' } }

          it 'is valid' do
            expect(message).to be_valid
          end
        end

        context 'when health_check type is process' do
          let(:params) { { health_check_type: 'process' } }

          it 'is valid' do
            expect(message).to be_valid
          end
        end

        context 'when health_check type is port' do
          let(:params) { { health_check_type: 'port' } }

          it 'is valid' do
            expect(message).to be_valid
          end
        end

        context 'when health_check type is invalid' do
          let(:params) { { health_check_type: 'metal' } }

          it 'is not valid' do
            expect(message).not_to be_valid
            expect(message.errors[:health_check_type]).to include('must be "port", "process", or "http"')
          end
        end
      end

      describe 'health_check_http_endpoint' do
        context 'when health_check_http_endpoint is not a valid URI path' do
          let(:params) { { health_check_http_endpoint: 'hello there' } }

          it 'is not valid' do
            expect(message).not_to be_valid
            expect(message.errors[:health_check_http_endpoint]).to include('must be a valid URI path')
          end
        end
      end

      context 'when health check type is not http and endpoint is specified' do
        let(:params) { { health_check_type: 'port', health_check_http_endpoint: '/endpoint' } }

        it 'is not valid' do
          expect(message).not_to be_valid
          expect(message.errors.count).to eq(1)
          expect(message.errors[:health_check_type]).to include('must be "http" to set a health check HTTP endpoint')
        end
      end

      context 'health check invocation timeout' do
        context 'its a number' do
          let(:params) { { health_check_invocation_timeout: 333 } }

          it 'is valid' do
            expect(message).to be_valid
          end
        end

        context 'not a number' do
          let(:params) { { health_check_invocation_timeout: 'velma' } }

          it 'is not valid' do
            expect(message).not_to be_valid
            expect(message.errors.count).to eq(1)
            expect(message.errors[:health_check_invocation_timeout]).to include('is not a number')
          end
        end

        context 'not a valid number' do
          context 'is negative' do
            let(:params) { { health_check_invocation_timeout: -10_000 } }

            it 'is not valid' do
              expect(message).not_to be_valid
              expect(message.errors.count).to eq(1)
              expect(message.errors[:health_check_invocation_timeout]).to include('must be greater than or equal to 1')
            end
          end

          context 'set to 0' do
            let(:params) { { health_check_invocation_timeout: 0 } }

            it 'is not valid' do
              expect(message).not_to be_valid
              expect(message.errors.count).to eq(1)
              expect(message.errors[:health_check_invocation_timeout]).to include('must be greater than or equal to 1')
            end
          end
        end
      end

      context 'health check interval' do
        context 'its a number' do
          let(:params) { { health_check_interval: 333 } }

          it 'is valid' do
            expect(message).to be_valid
          end
        end

        context 'is not a number' do
          let(:params) { { health_check_interval: 'velma' } }

          it 'is not valid' do
            expect(message).not_to be_valid
            expect(message.errors.count).to eq(1)
            expect(message.errors[:health_check_interval]).to include('is not a number')
          end
        end

        context 'not a valid number' do
          context 'negative' do
            let(:params) { { health_check_interval: -10_000 } }

            it 'is not valid' do
              expect(message).not_to be_valid
              expect(message.errors.count).to eq(1)
              expect(message.errors[:health_check_interval]).to include('must be greater than or equal to 1')
            end
          end

          context 'set to 0' do
            let(:params) { { health_check_interval: 0 } }

            it 'is not valid' do
              expect(message).not_to be_valid
              expect(message.errors.count).to eq(1)
              expect(message.errors[:health_check_interval]).to include('must be greater than or equal to 1')
            end
          end
        end
      end

      context 'readiness health check properties' do
        describe 'readiness_health_check_type' do
          context 'when readiness_health_check type is port' do
            let(:params) { { readiness_health_check_type: 'port' } }

            it 'is valid' do
              expect(message).to be_valid
            end
          end

          context 'when readiness_health_check type is process' do
            let(:params) { { readiness_health_check_type: 'process' } }

            it 'is valid' do
              expect(message).to be_valid
            end
          end

          context 'when readiness_health_check type is http' do
            let(:params) { { readiness_health_check_type: 'http' } }

            it 'is valid' do
              expect(message).to be_valid
            end
          end

          context 'when readiness_health_check type is invalid' do
            let(:params) { { readiness_health_check_type: 'meow' } }

            it 'is not valid' do
              expect(message).not_to be_valid
              expect(message.errors[:readiness_health_check_type]).to include('must be "port", "process", or "http"')
            end
          end
        end

        context 'when readiness health check timeout is a number' do
          let(:params) { { readiness_health_check_invocation_timeout: 333 } }

          it 'is valid' do
            expect(message).to be_valid
          end
        end

        context 'when readiness health check timeout is not a number' do
          let(:params) { { readiness_health_check_invocation_timeout: 'velma' } }

          it 'is not valid' do
            expect(message).not_to be_valid
            expect(message.errors.count).to eq(1)
            expect(message.errors[:readiness_health_check_invocation_timeout]).to include('is not a number')
          end
        end

        context 'when readiness health check timeout is not a valid number' do
          context 'when readiness health check timeout is negative' do
            let(:params) { { readiness_health_check_invocation_timeout: -10_000 } }

            it 'is not valid' do
              expect(message).not_to be_valid
              expect(message.errors.count).to eq(1)
              expect(message.errors[:readiness_health_check_invocation_timeout]).to include('must be greater than or equal to 1')
            end
          end

          context 'when readiness health check timeout is 0' do
            let(:params) { { readiness_health_check_invocation_timeout: 0 } }

            it 'is not valid' do
              expect(message).not_to be_valid
              expect(message.errors.count).to eq(1)
              expect(message.errors[:readiness_health_check_invocation_timeout]).to include('must be greater than or equal to 1')
            end
          end
        end

        describe 'readiness health check interval' do
          context 'its a number' do
            let(:params) { { readiness_health_check_interval: 333 } }

            it 'is valid' do
              expect(message).to be_valid
            end
          end

          context 'is not a number' do
            let(:params) { { readiness_health_check_interval: 'velma' } }

            it 'is not valid' do
              expect(message).not_to be_valid
              expect(message.errors.count).to eq(1)
              expect(message.errors[:readiness_health_check_interval]).to include('is not a number')
            end
          end

          context 'not a valid number' do
            context 'negative' do
              let(:params) { { readiness_health_check_interval: -10_000 } }

              it 'is not valid' do
                expect(message).not_to be_valid
                expect(message.errors.count).to eq(1)
                expect(message.errors[:readiness_health_check_interval]).to include('must be greater than or equal to 1')
              end
            end

            context 'set to 0' do
              let(:params) { { readiness_health_check_interval: 0 } }

              it 'is not valid' do
                expect(message).not_to be_valid
                expect(message.errors.count).to eq(1)
                expect(message.errors[:readiness_health_check_interval]).to include('must be greater than or equal to 1')
              end
            end
          end
        end

        describe 'readiness_health_check_http_endpoint' do
          context 'when readiness_health_check_http_endpoint is a valid URI path and type is http' do
            let(:params) { { readiness_health_check_type: 'http', readiness_health_check_http_endpoint: '/validendpoint' } }

            it 'is valid' do
              expect(message).to be_valid
            end
          end

          context 'when readiness_health_check_http_endpoint is not a valid URI path' do
            let(:params) { { readiness_health_check_http_endpoint: 'hello there' } }

            it 'is not valid' do
              expect(message).not_to be_valid
              expect(message.errors[:readiness_health_check_http_endpoint]).to include('must be a valid URI path')
            end
          end

          context 'when health check type is not http and endpoint is specified' do
            let(:params) { { readiness_health_check_type: 'port', readiness_health_check_http_endpoint: '/endpoint' } }

            it 'is not valid' do
              expect(message).not_to be_valid
              expect(message.errors.count).to eq(1)
              expect(message.errors[:readiness_health_check_type]).to include('must be "http" to set a health check HTTP endpoint')
            end
          end
        end
      end

      describe 'timeout' do
        context 'when timeout is not an number' do
          let(:params) { { timeout: 'hello there' } }

          it 'is not valid' do
            expect(message).not_to be_valid
            expect(message.errors[:timeout]).to include('is not a number')
          end
        end

        context 'when timeout is not an integer' do
          let(:params) { { timeout: 1.1 } }

          it 'is not valid' do
            expect(message).not_to be_valid
            expect(message.errors[:timeout]).to include('must be an integer')
          end
        end

        context 'when timeout is less than one' do
          let(:params) { { timeout: 0 } }

          it 'is not valid' do
            expect(message).not_to be_valid
            expect(message.errors[:timeout]).to include('must be greater than or equal to 1')
          end
        end
      end
    end

    describe '#requested?' do
      attribute_mappings = {
        'timeout' => :health_check_timeout,
        'health_check_http_endpoint' => :health_check_endpoint,
        'health_check_type' => :health_check_type,
        'command' => :command
      }

      attribute_mappings.each do |manifest_attribute, message_attribute|
        context "when #{manifest_attribute} is requested" do
          let(:body) { { manifest_attribute => 'value' } }

          it "returns true for #{message_attribute}" do
            expect(message.requested?(message_attribute)).to be true
          end
        end

        context "when #{manifest_attribute} is not requested" do
          let(:body) { {} }

          it "returns false for #{message_attribute}" do
            expect(message.requested?(message_attribute)).to be false
          end
        end
      end
    end
  end
end