cloudfoundry/cloud_controller_ng

View on GitHub
spec/unit/messages/organization_quotas_create_message_spec.rb

Summary

Maintainability
D
1 day
Test Coverage
require 'spec_helper'
require 'messages/organization_quotas_create_message'

module VCAP::CloudController
  RSpec.describe OrganizationQuotasCreateMessage do
    subject { OrganizationQuotasCreateMessage.new(params) }
    let(:relationships) do
      {
        organizations: {
          data: []
        }
      }
    end

    describe 'validations' do
      context 'when no params are given' do
        let(:params) {}

        it 'is not valid' do
          expect(subject).not_to be_valid
          expect(subject.errors[:name]).to eq ["can't be blank"]
        end
      end

      context 'when unexpected keys are requested' do
        let(:params) { { unexpected: 'meow', name: 'the-name' } }

        it 'is not valid' do
          expect(subject).not_to be_valid
          expect(subject.errors.full_messages[0]).to include("Unknown field(s): 'unexpected'")
        end
      end

      describe 'name' do
        context 'when it is non-alphanumeric' do
          let(:params) { { name: 'thë-name', relationships: relationships } }

          it { is_expected.to be_valid }
        end

        context 'when it contains hyphens' do
          let(:params) { { name: 'a-z', relationships: relationships } }

          it { is_expected.to be_valid }
        end

        context 'when it contains capital ascii' do
          let(:params) { { name: 'AZ', relationships: relationships } }

          it { is_expected.to be_valid }
        end

        context 'when it is at max length' do
          let(:params) { { name: 'B' * OrganizationQuotasCreateMessage::MAX_ORGANIZATION_QUOTA_NAME_LENGTH, relationships: relationships } }

          it { is_expected.to be_valid }
        end

        context 'when it is too long' do
          let(:params) { { name: 'B' * (OrganizationQuotasCreateMessage::MAX_ORGANIZATION_QUOTA_NAME_LENGTH + 1), relationships: relationships } }

          it 'is not valid' do
            expect(subject).not_to be_valid
            expect(subject.errors[:name]).to contain_exactly('is too long (maximum is 250 characters)')
          end
        end

        context 'when it is blank' do
          let(:params) { { name: '', relationships: relationships } }

          it 'is not valid' do
            expect(subject).not_to be_valid
            expect(subject.errors[:name]).to include("can't be blank")
          end
        end
      end

      describe 'apps' do
        context 'value for apps is not a hash' do
          let(:params) do
            {
              name: 'my-name',
              apps: true
            }
          end

          it 'is not valid' do
            expect(subject).not_to be_valid
            expect(subject.errors.full_messages[0]).to include('Apps must be an object')
          end
        end

        context 'invalid keys are passed in' do
          let(:params) do
            {
              name: 'my-name',
              apps: { bad_key: 'bob' }
            }
          end

          it 'is not valid' do
            expect(subject).not_to be_valid
            expect(subject.errors.full_messages[0]).to include("Unknown field(s): 'bad_key'")
          end
        end

        describe 'total_memory_in_mb' do
          context 'when the type is a string' do
            let(:params) do
              {
                name: 'my-name',
                apps: { total_memory_in_mb: 'bob' },
                relationships: relationships
              }
            end

            it 'is not valid' do
              expect(subject).not_to be_valid
              expect(subject.errors[:apps]).to contain_exactly('Total memory in mb is not a number')
            end
          end

          context 'when the type is decimal' do
            let(:params) do
              {
                name: 'my-name',
                apps: { total_memory_in_mb: 1.1 },
                relationships: relationships
              }
            end

            it 'is not valid' do
              expect(subject).not_to be_valid
              expect(subject.errors[:apps]).to contain_exactly('Total memory in mb must be an integer')
            end
          end

          context 'when the type is a negative integer' do
            let(:params) do
              {
                name: 'my-name',
                apps: { total_memory_in_mb: -1 },
                relationships: relationships
              }
            end

            it 'is not valid because "unlimited" is set with null, not -1, in V3' do
              expect(subject).not_to be_valid
              expect(subject.errors[:apps]).to contain_exactly('Total memory in mb must be greater than or equal to 0')
            end
          end

          context 'when the type is zero' do
            let(:params) do
              {
                name: 'my-name',
                apps: { total_memory_in_mb: 0 },
                relationships: relationships
              }
            end

            it { is_expected.to be_valid }
          end

          context 'when the type is nil (unlimited)' do
            let(:params) do
              {
                name: 'my-name',
                apps: { total_memory_in_mb: nil },
                relationships: relationships
              }
            end

            it { is_expected.to be_valid }
          end
        end

        describe 'per_process_memory_in_mb' do
          context 'when the type is a string' do
            let(:params) do
              {
                name: 'my-name',
                apps: { per_process_memory_in_mb: 'bob' },
                relationships: relationships
              }
            end

            it 'is not valid' do
              expect(subject).not_to be_valid
              expect(subject.errors[:apps]).to contain_exactly('Per process memory in mb is not a number')
            end
          end

          context 'when the type is decimal' do
            let(:params) do
              {
                name: 'my-name',
                apps: { per_process_memory_in_mb: 1.1 },
                relationships: relationships
              }
            end

            it 'is not valid' do
              expect(subject).not_to be_valid
              expect(subject.errors[:apps]).to contain_exactly('Per process memory in mb must be an integer')
            end
          end

          context 'when the type is a negative integer' do
            let(:params) do
              {
                name: 'my-name',
                apps: { per_process_memory_in_mb: -1 },
                relationships: relationships
              }
            end

            it 'is not valid because "unlimited" is set with null, not -1, in V3' do
              expect(subject).not_to be_valid
              expect(subject.errors[:apps]).to contain_exactly('Per process memory in mb must be greater than or equal to 0')
            end
          end

          context 'when the type is zero' do
            let(:params) do
              {
                name: 'my-name',
                apps: { per_process_memory_in_mb: 0 },
                relationships: relationships
              }
            end

            it { is_expected.to be_valid }
          end

          context 'when the type is nil (unlimited)' do
            let(:params) do
              {
                name: 'my-name',
                apps: { per_process_memory_in_mb: nil },
                relationships: relationships
              }
            end

            it { is_expected.to be_valid }
          end
        end

        describe 'log_rate_limit_in_bytes_per_second' do
          context 'when the type is a string' do
            let(:params) do
              {
                name: 'my-name',
                apps: { log_rate_limit_in_bytes_per_second: 'bob' },
                relationships: relationships
              }
            end

            it 'is not valid' do
              expect(subject).not_to be_valid
              expect(subject.errors[:apps]).to contain_exactly('Log rate limit in bytes per second is not a number')
            end
          end

          context 'when the type is decimal' do
            let(:params) do
              {
                name: 'my-name',
                apps: { log_rate_limit_in_bytes_per_second: 1.1 },
                relationships: relationships
              }
            end

            it 'is not valid' do
              expect(subject).not_to be_valid
              expect(subject.errors[:apps]).to contain_exactly('Log rate limit in bytes per second must be an integer')
            end
          end

          context 'when the type is a negative integer' do
            let(:params) do
              {
                name: 'my-name',
                apps: { log_rate_limit_in_bytes_per_second: -1 },
                relationships: relationships
              }
            end

            it 'is not valid because "unlimited" is set with null, not -1, in V3' do
              expect(subject).not_to be_valid
              expect(subject.errors[:apps]).to contain_exactly('Log rate limit in bytes per second must be greater than or equal to 0')
            end
          end

          context 'when the type is zero' do
            let(:params) do
              {
                name: 'my-name',
                apps: { log_rate_limit_in_bytes_per_second: 0 },
                relationships: relationships
              }
            end

            it { is_expected.to be_valid }
          end

          context 'when the type is nil (unlimited)' do
            let(:params) do
              {
                name: 'my-name',
                apps: { log_rate_limit_in_bytes_per_second: nil },
                relationships: relationships
              }
            end

            it { is_expected.to be_valid }
          end
        end

        describe 'total_instances' do
          context 'when the type is a string' do
            let(:params) do
              {
                name: 'my-name',
                apps: { total_instances: 'bob' },
                relationships: relationships
              }
            end

            it 'is not valid' do
              expect(subject).not_to be_valid
              expect(subject.errors[:apps]).to contain_exactly('Total instances is not a number')
            end
          end

          context 'when the type is decimal' do
            let(:params) do
              {
                name: 'my-name',
                apps: { total_instances: 1.1 },
                relationships: relationships
              }
            end

            it 'is not valid' do
              expect(subject).not_to be_valid
              expect(subject.errors[:apps]).to contain_exactly('Total instances must be an integer')
            end
          end

          context 'when the type is a negative integer' do
            let(:params) do
              {
                name: 'my-name',
                apps: { total_instances: -1 },
                relationships: relationships
              }
            end

            it 'is not valid because "unlimited" is set with null, not -1, in V3' do
              expect(subject).not_to be_valid
              expect(subject.errors[:apps]).to contain_exactly('Total instances must be greater than or equal to 0')
            end
          end

          context 'when the type is zero' do
            let(:params) do
              {
                name: 'my-name',
                apps: { total_instances: 0 },
                relationships: relationships
              }
            end

            it { is_expected.to be_valid }
          end

          context 'when the type is nil (unlimited)' do
            let(:params) do
              {
                name: 'my-name',
                apps: { total_instances: nil },
                relationships: relationships
              }
            end

            it { is_expected.to be_valid }
          end
        end

        describe 'per_app_tasks' do
          context 'when the type is a string' do
            let(:params) do
              {
                name: 'my-name',
                apps: { per_app_tasks: 'bob' }
              }
            end

            it 'is not valid' do
              expect(subject).not_to be_valid
              expect(subject.errors[:apps]).to contain_exactly('Per app tasks is not a number')
            end
          end

          context 'when the type is decimal' do
            let(:params) do
              {
                name: 'my-name',
                apps: { per_app_tasks: 1.1 }
              }
            end

            it 'is not valid' do
              expect(subject).not_to be_valid
              expect(subject.errors[:apps]).to contain_exactly('Per app tasks must be an integer')
            end
          end

          context 'when the type is a negative integer' do
            let(:params) do
              {
                name: 'my-name',
                apps: { per_app_tasks: -1 }
              }
            end

            it 'is not valid because "unlimited" is set with null, not -1, in V3' do
              expect(subject).not_to be_valid
              expect(subject.errors[:apps]).to contain_exactly('Per app tasks must be greater than or equal to 0')
            end
          end

          context 'when the type is zero' do
            let(:params) do
              {
                name: 'my-name',
                apps: { per_app_tasks: 0 }
              }
            end

            it { is_expected.to be_valid }
          end

          context 'when the type is nil (unlimited)' do
            let(:params) do
              {
                name: 'my-name',
                apps: { per_app_tasks: nil }
              }
            end

            it { is_expected.to be_valid }
          end
        end
      end

      describe 'services' do
        context 'value for services is not a hash' do
          let(:params) do
            {
              name: 'my-name',
              services: true
            }
          end

          it 'is not valid' do
            expect(subject).not_to be_valid
            expect(subject.errors.full_messages[0]).to include('Services must be an object')
          end
        end

        context 'invalid keys are passed in' do
          let(:params) do
            {
              name: 'my-name',
              services: { bad_key: 'billy' }
            }
          end

          it 'is not valid' do
            expect(subject).not_to be_valid
            expect(subject.errors.full_messages[0]).to include("Unknown field(s): 'bad_key'")
          end
        end

        describe 'total_service_instances' do
          context 'when the type is a string' do
            let(:params) do
              {
                name: 'my-name',
                services: { total_service_instances: 'bob' },
                relationships: relationships
              }
            end

            it 'is not valid' do
              expect(subject).not_to be_valid
              expect(subject.errors[:services]).to contain_exactly('Total service instances is not a number')
            end
          end

          context 'when the type is decimal' do
            let(:params) do
              {
                name: 'my-name',
                services: { total_service_instances: 1.1 },
                relationships: relationships
              }
            end

            it 'is not valid' do
              expect(subject).not_to be_valid
              expect(subject.errors[:services]).to contain_exactly('Total service instances must be an integer')
            end
          end

          context 'when the type is a negative integer' do
            let(:params) do
              {
                name: 'my-name',
                services: { total_service_instances: -1 },
                relationships: relationships
              }
            end

            it 'is not valid because "unlimited" is set with null, not -1, in V3' do
              expect(subject).not_to be_valid
              expect(subject.errors[:services]).to contain_exactly('Total service instances must be greater than or equal to 0')
            end
          end

          context 'when the type is zero' do
            let(:params) do
              {
                name: 'my-name',
                services: { total_service_instances: 0 },
                relationships: relationships
              }
            end

            it { is_expected.to be_valid }
          end

          context 'when the type is nil (unlimited)' do
            let(:params) do
              {
                name: 'my-name',
                services: { total_service_instances: nil },
                relationships: relationships
              }
            end

            it { is_expected.to be_valid }
          end
        end

        describe 'total_service_keys' do
          context 'when the type is a string' do
            let(:params) do
              {
                name: 'my-name',
                services: { total_service_keys: 'bob' },
                relationships: relationships
              }
            end

            it 'is not valid' do
              expect(subject).not_to be_valid
              expect(subject.errors[:services]).to contain_exactly('Total service keys is not a number')
            end
          end

          context 'when the type is decimal' do
            let(:params) do
              {
                name: 'my-name',
                services: { total_service_keys: 1.1 },
                relationships: relationships
              }
            end

            it 'is not valid' do
              expect(subject).not_to be_valid
              expect(subject.errors[:services]).to contain_exactly('Total service keys must be an integer')
            end
          end

          context 'when the type is a negative integer' do
            let(:params) do
              {
                name: 'my-name',
                services: { total_service_keys: -1 },
                relationships: relationships
              }
            end

            it 'is not valid because "unlimited" is set with null, not -1, in V3' do
              expect(subject).not_to be_valid
              expect(subject.errors[:services]).to contain_exactly('Total service keys must be greater than or equal to 0')
            end
          end

          context 'when the type is zero' do
            let(:params) do
              {
                name: 'my-name',
                services: { total_service_keys: 0 },
                relationships: relationships
              }
            end

            it { is_expected.to be_valid }
          end

          context 'when the type is nil (unlimited)' do
            let(:params) do
              {
                name: 'my-name',
                services: { total_service_keys: nil },
                relationships: relationships
              }
            end

            it { is_expected.to be_valid }
          end
        end

        describe 'paid_services_allowed' do
          context 'when it is a boolean' do
            let(:params) do
              {
                name: 'thë-name',
                services: { paid_services_allowed: false }
              }
            end

            it { is_expected.to be_valid }
          end

          context 'when it is not a boolean' do
            let(:params) do
              {
                name: 'thë-name',
                services: { paid_services_allowed: 'b' }
              }
            end

            it 'is not valid' do
              expect(subject).not_to be_valid
              expect(subject.errors[:services]).to contain_exactly('Paid services allowed must be a boolean')
            end
          end
        end
      end

      describe 'routes' do
        context 'value for routes is not a hash' do
          let(:params) do
            {
              name: 'my-name',
              routes: true
            }
          end

          it 'is not valid' do
            expect(subject).not_to be_valid
            expect(subject.errors.full_messages[0]).to include('Routes must be an object')
          end
        end

        context 'invalid keys are passed in' do
          let(:params) do
            {
              name: 'my-name',
              routes: { bad_key: 'billy' }
            }
          end

          it 'is not valid' do
            expect(subject).not_to be_valid
            expect(subject.errors.full_messages[0]).to include("Unknown field(s): 'bad_key'")
          end
        end

        describe 'total_routes' do
          context 'when the type is a string' do
            let(:params) do
              {
                name: 'my-name',
                routes: { total_routes: 'bob' }
              }
            end

            it 'is not valid' do
              expect(subject).not_to be_valid
              expect(subject.errors[:routes]).to contain_exactly('Total routes is not a number')
            end
          end

          context 'when the type is decimal' do
            let(:params) do
              {
                name: 'my-name',
                routes: { total_routes: 1.1 }
              }
            end

            it 'is not valid' do
              expect(subject).not_to be_valid
              expect(subject.errors[:routes]).to contain_exactly('Total routes must be an integer')
            end
          end

          context 'when the type is a negative integer' do
            let(:params) do
              {
                name: 'my-name',
                routes: { total_routes: -1 }
              }
            end

            it 'is not valid because "unlimited" is set with null, not -1, in V3' do
              expect(subject).not_to be_valid
              expect(subject.errors[:routes]).to contain_exactly('Total routes must be greater than or equal to 0')
            end
          end

          context 'when the type is zero' do
            let(:params) do
              {
                name: 'my-name',
                routes: { total_routes: 0 }
              }
            end

            it { is_expected.to be_valid }
          end

          context 'when the type is nil (unlimited)' do
            let(:params) do
              {
                name: 'my-name',
                routes: { total_routes: nil }
              }
            end

            it { is_expected.to be_valid }
          end
        end

        describe 'total_reserved_ports' do
          context 'when the type is a string' do
            let(:params) do
              {
                name: 'my-name',
                routes: { total_reserved_ports: 'bob' }
              }
            end

            it 'is not valid' do
              expect(subject).not_to be_valid
              expect(subject.errors[:routes]).to contain_exactly('Total reserved ports is not a number')
            end
          end

          context 'when the type is decimal' do
            let(:params) do
              {
                name: 'my-name',
                routes: { total_reserved_ports: 1.1 }
              }
            end

            it 'is not valid' do
              expect(subject).not_to be_valid
              expect(subject.errors[:routes]).to contain_exactly('Total reserved ports must be an integer')
            end
          end

          context 'when the type is a negative integer' do
            let(:params) do
              {
                name: 'my-name',
                routes: { total_reserved_ports: -1 }
              }
            end

            it 'is not valid because "unlimited" is set with null, not -1, in V3' do
              expect(subject).not_to be_valid
              expect(subject.errors[:routes]).to contain_exactly('Total reserved ports must be greater than or equal to 0')
            end
          end

          context 'when the type is zero' do
            let(:params) do
              {
                name: 'my-name',
                routes: { total_reserved_ports: 0 }
              }
            end

            it { is_expected.to be_valid }
          end

          context 'when the type is nil (unlimited)' do
            let(:params) do
              {
                name: 'my-name',
                routes: { total_reserved_ports: nil }
              }
            end

            it { is_expected.to be_valid }
          end
        end
      end

      describe 'domains' do
        context 'value for domains is not a hash' do
          let(:params) do
            {
              name: 'my-name',
              domains: true
            }
          end

          it 'is not valid' do
            expect(subject).not_to be_valid
            expect(subject.errors.full_messages[0]).to include('Domains must be an object')
          end
        end

        context 'invalid keys are passed in' do
          let(:params) do
            {
              name: 'my-name',
              domains: { bad_key: 'billy' }
            }
          end

          it 'is not valid' do
            expect(subject).not_to be_valid
            expect(subject.errors.full_messages[0]).to include("Unknown field(s): 'bad_key'")
          end

          describe 'total_domains' do
            context 'when the type is a string' do
              let(:params) do
                {
                  name: 'my-name',
                  domains: { total_domains: 'bob' }
                }
              end

              it 'is not valid' do
                expect(subject).not_to be_valid
                expect(subject.errors[:domains]).to contain_exactly('Total domains is not a number')
              end
            end

            context 'when the type is decimal' do
              let(:params) do
                {
                  name: 'my-name',
                  domains: { total_domains: 1.1 }
                }
              end

              it 'is not valid' do
                expect(subject).not_to be_valid
                expect(subject.errors[:domains]).to contain_exactly('Total domains must be an integer')
              end
            end

            context 'when the type is a negative integer' do
              let(:params) do
                {
                  name: 'my-name',
                  domains: { total_domains: -1 }
                }
              end

              it 'is not valid because "unlimited" is set with null, not -1, in V3' do
                expect(subject).not_to be_valid
                expect(subject.errors[:domains]).to contain_exactly('Total domains must be greater than or equal to 0')
              end
            end

            context 'when the type is zero' do
              let(:params) do
                {
                  name: 'my-name',
                  domains: { total_domains: 0 }
                }
              end

              it { is_expected.to be_valid }
            end

            context 'when the type is nil (unlimited)' do
              let(:params) do
                {
                  name: 'my-name',
                  domains: { total_domains: nil }
                }
              end

              it { is_expected.to be_valid }
            end
          end
        end
      end

      describe 'relationships' do
        context 'given no organization guids' do
          let(:params) do
            {
              name: 'kris'
            }
          end

          it { is_expected.to be_valid }
        end

        context 'given multiple organization guids' do
          let(:params) do
            {
              name: 'kim',
              relationships: {
                organizations: {
                  data: [
                    { guid: 'KKW-beauty' },
                    { guid: 'skims' }
                  ]
                }
              }
            }
          end

          it { is_expected.to be_valid }
        end

        context 'given malformed data array' do
          let(:params) do
            {
              name: 'kourtney',
              relationships: {
                organizations: { guid: 'poosh' }
              }
            }
          end

          it { is_expected.not_to be_valid }
        end

        context 'given malformed organization guids' do
          let(:params) do
            {
              name: 'rob',
              relationships: {
                organizations: {
                  data: [
                    { guid: 150_000 }
                  ]
                }
              }
            }
          end

          it { is_expected.not_to be_valid }
        end
      end
    end
  end
end