cloudfoundry/cloud_controller_ng

View on GitHub
spec/unit/presenters/v3/process_stats_presenter_spec.rb

Summary

Maintainability
A
3 hrs
Test Coverage
require 'spec_helper'
require 'presenters/v3/process_stats_presenter'

module VCAP::CloudController::Presenters::V3
  RSpec.describe ProcessStatsPresenter do
    subject(:presenter) { ProcessStatsPresenter.new(process.type, stats_for_process) }
    let(:process) { VCAP::CloudController::ProcessModelFactory.make }
    let(:warnings) { [] }

    describe '#present_stats_hash' do
      let(:process_usage) { process.type.usage }
      let(:net_info_1) do
        {
          address: '1.2.3.4',
          instance_address: '5.6.7.8',
          ports: [
            {
              host_port: 8080,
              container_port: 1234,
              host_tls_proxy_port: 61_002,
              container_tls_proxy_port: 61_003
            }, {
              host_port: 3000,
              container_port: 4000,
              host_tls_proxy_port: 0,
              container_tls_proxy_port: 0
            }
          ]
        }
      end

      let(:net_info_2) do
        {
          address: '',
          instance_address: '',
          ports: nil
        }
      end

      let(:instance_ports_1) do
        [
          {
            external: 8080,
            internal: 1234,
            external_tls_proxy_port: 61_002,
            internal_tls_proxy_port: 61_003
          }, {
            external: 3000,
            internal: 4000,
            external_tls_proxy_port: nil,
            internal_tls_proxy_port: nil
          }
        ]
      end

      let(:instance_ports_2) { [] }

      let(:stats_for_process) do
        {
          0 => {
            state: 'RUNNING',
            routable: true,
            isolation_segment: 'hecka-compliant',
            stats: {
              name: process.name,
              uris: process.uris,
              host: 'myhost',
              net_info: net_info_1,
              uptime: 12_345,
              mem_quota: process[:memory] * 1024 * 1024,
              disk_quota: process[:disk_quota] * 1024 * 1024,
              log_rate_limit: process[:log_rate_limit],
              fds_quota: process.file_descriptors,
              usage: {
                time: '2015-12-08 16:54:48 -0800',
                cpu: 80,
                cpu_entitlement: 85,
                mem: 128,
                disk: 1024,
                log_rate: 2048
              }
            }
          },
          1 => {
            state: 'CRASHED',
            details: 'some-details',
            routable: false,
            stats: {
              name: process.name,
              uris: process.uris,
              host: 'toast',
              net_info: net_info_2,
              uptime: 42,
              mem_quota: process[:memory] * 1024 * 1024,
              disk_quota: process[:disk_quota] * 1024 * 1024,
              log_rate_limit: process[:log_rate_limit],
              fds_quota: process.file_descriptors,
              usage: {
                time: '2015-03-13 16:54:48 -0800',
                cpu: 70,
                cpu_entitlement: 75,
                mem: 128,
                disk: 1024,
                log_rate: 7168
              }
            }
          },
          2 => {
            state: 'DOWN',
            routable: false,
            details: 'you must construct additional pylons',
            stats: {
              uptime: 0
            }
          }
        }
      end

      it 'presents the process stats as a hash' do
        result = presenter.present_stats_hash

        expect(result[0][:type]).to eq(process.type)
        expect(result[0][:index]).to eq(0)
        expect(result[0][:state]).to eq('RUNNING')
        expect(result[0][:routable]).to be(true)
        expect(result[0][:details]).to be_nil
        expect(result[0][:isolation_segment]).to eq('hecka-compliant')
        expect(result[0][:host]).to eq('myhost')
        expect(result[0][:instance_internal_ip]).to eq('5.6.7.8')
        expect(result[0][:instance_ports]).to eq(instance_ports_1)
        expect(result[0][:uptime]).to eq(12_345)
        expect(result[0][:mem_quota]).to eq(process[:memory] * 1024 * 1024)
        expect(result[0][:disk_quota]).to eq(process[:disk_quota] * 1024 * 1024)
        expect(result[0][:log_rate_limit]).to eq(process[:log_rate_limit])
        expect(result[0][:fds_quota]).to eq(process.file_descriptors)
        expect(result[0][:usage]).to eq({ time: '2015-12-08 16:54:48 -0800',
                                          cpu: 80,
                                          cpu_entitlement: 85,
                                          mem: 128,
                                          disk: 1024,
                                          log_rate: 2048 })

        expect(result[1][:type]).to eq(process.type)
        expect(result[1][:index]).to eq(1)
        expect(result[1][:state]).to eq('CRASHED')
        expect(result[1][:routable]).to be(false)
        expect(result[1][:details]).to eq('some-details')
        expect(result[1][:isolation_segment]).to be_nil
        expect(result[1][:host]).to eq('toast')
        expect(result[1][:instance_ports]).to eq(instance_ports_2)
        expect(result[1][:uptime]).to eq(42)
        expect(result[1][:usage]).to eq({ time: '2015-03-13 16:54:48 -0800',
                                          cpu: 70,
                                          cpu_entitlement: 75,
                                          mem: 128,
                                          disk: 1024,
                                          log_rate: 7168 })

        expect(result[2]).to eq(
          type: process.type,
          index: 2,
          state: 'DOWN',
          routable: false,
          uptime: 0,
          isolation_segment: nil,
          details: 'you must construct additional pylons'
        )
      end

      context 'diego does not provide the "routable" field' do
        let(:stats_for_process) do
          {
            0 => {
              state: 'RUNNING',
              routable: nil,
              isolation_segment: 'hecka-compliant',
              stats: {
                name: process.name,
                uris: process.uris,
                host: 'myhost',
                net_info: net_info_1,
                uptime: 12_345,
                mem_quota: process[:memory] * 1024 * 1024,
                disk_quota: process[:disk_quota] * 1024 * 1024,
                log_rate_limit: process[:log_rate_limit],
                fds_quota: process.file_descriptors,
                usage: {
                  time: '2015-12-08 16:54:48 -0800',
                  cpu: 80,
                  cpu_entitlement: 85,
                  mem: 128,
                  disk: 1024,
                  log_rate: 2048
                }
              }
            }
          }
        end

        it 'does not set routable, with state of RUNNING' do
          result = presenter.present_stats_hash

          expect(result[0][:state]).to eq('RUNNING')
          expect(result[0]).to have_key(:routable)
          expect(result[0][:routable]).to be_nil
        end
      end

      context 'the process is running, but not routable due to failed readiness check in diego' do
        let(:stats_for_process) do
          {
            0 => {
              state: 'RUNNING',
              routable: false,
              isolation_segment: 'hecka-compliant',
              stats: {
                name: process.name,
                uris: process.uris,
                host: 'myhost',
                net_info: net_info_1,
                uptime: 12_345,
                mem_quota: process[:memory] * 1024 * 1024,
                disk_quota: process[:disk_quota] * 1024 * 1024,
                log_rate_limit: process[:log_rate_limit],
                fds_quota: process.file_descriptors,
                usage: {
                  time: '2015-12-08 16:54:48 -0800',
                  cpu: 80,
                  cpu_entitlement: 85,
                  mem: 128,
                  disk: 1024,
                  log_rate: 2048
                }
              }
            }
          }
        end

        it 'sets routable to false, with state of RUNNING' do
          result = presenter.present_stats_hash

          expect(result[0][:state]).to eq('RUNNING')
          expect(result[0][:routable]).to be(false)
        end
      end

      context 'the process is running on opi and not diego, so *_tls_proxy_ports are not included in the port struct' do
        let(:net_info_1) do
          {
            address: '1.2.3.4',
            instance_address: '5.6.7.8',
            ports: [
              {
                host_port: 8080,
                container_port: 1234
              }, {
                host_port: 3000,
                container_port: 4000
              }
            ]
          }
        end

        let(:instance_ports_1) do
          [
            {
              external: 8080,
              internal: 1234,
              external_tls_proxy_port: nil,
              internal_tls_proxy_port: nil
            }, {
              external: 3000,
              internal: 4000,
              external_tls_proxy_port: nil,
              internal_tls_proxy_port: nil
            }
          ]
        end

        it 'does not error and sets the *_tls_proxy_port values to nil' do
          result = presenter.present_stats_hash

          expect(result[0][:type]).to eq(process.type)
          expect(result[0][:index]).to eq(0)
          expect(result[0][:state]).to eq('RUNNING')
          expect(result[0][:details]).to be_nil
          expect(result[0][:isolation_segment]).to eq('hecka-compliant')
          expect(result[0][:host]).to eq('myhost')
          expect(result[0][:instance_internal_ip]).to eq('5.6.7.8')
          expect(result[0][:instance_ports]).to eq(instance_ports_1)
          expect(result[0][:uptime]).to eq(12_345)
          expect(result[0][:mem_quota]).to eq(process[:memory] * 1024 * 1024)
          expect(result[0][:disk_quota]).to eq(process[:disk_quota] * 1024 * 1024)
          expect(result[0][:log_rate_limit]).to eq(process[:log_rate_limit])
          expect(result[0][:fds_quota]).to eq(process.file_descriptors)
          expect(result[0][:usage]).to eq({ time: '2015-12-08 16:54:48 -0800',
                                            cpu: 80,
                                            cpu_entitlement: 85,
                                            mem: 128,
                                            disk: 1024,
                                            log_rate: 2048 })
        end
      end

      context 'the process stats are missing metrics data' do
        let(:stats_for_process) do
          {
            0 => {
              state: 'RUNNING',
              isolation_segment: 'hecka-compliant',
              stats: {
                name: process.name,
                uris: process.uris,
                host: 'myhost',
                net_info: net_info_1,
                uptime: 12_345,
                fds_quota: process.file_descriptors,
                usage: {}
              }
            }
          }
        end

        it 'presents the process stats as a hash' do
          result = presenter.present_stats_hash

          expect(result[0][:type]).to eq(process.type)
          expect(result[0][:index]).to eq(0)
          expect(result[0][:state]).to eq('RUNNING')
          expect(result[0][:details]).to be_nil
          expect(result[0][:isolation_segment]).to eq('hecka-compliant')
          expect(result[0][:host]).to eq('myhost')
          expect(result[0][:instance_internal_ip]).to eq('5.6.7.8')
          expect(result[0][:instance_ports]).to eq(instance_ports_1)
          expect(result[0][:uptime]).to eq(12_345)
          expect(result[0][:mem_quota]).to be_nil
          expect(result[0][:disk_quota]).to be_nil
          expect(result[0][:log_rate_limit]).to be_nil
          expect(result[0][:fds_quota]).to eq(process.file_descriptors)
          expect(result[0][:usage]).to eq({})
        end
      end
    end

    describe '#to_hash' do
      let(:stats_for_process) { {} }

      it 'maps the content of #present_stats_hash to :resources' do
        allow(presenter).to receive(:present_stats_hash).and_return({ a: 1, b: 2 })
        expect(presenter.to_hash).to eq(resources: { a: 1, b: 2 })
      end
    end
  end
end