Sign upLogin

cloudfoundry/dea_ng

View on GitHub
Star

Showing 89 of 89 total issues

Method download! has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def download!(&blk)
    destination_file.binmode
    sha1 = Digest::SHA1.new

    http = EM::HttpRequest.new(source_uri, :inactivity_timeout => 30).get
Severity: Minor
Found in lib/dea/utils/download.rb - About 1 hr to fix

    Method instances_filtered_by_message has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

        def instances_filtered_by_message(message)
      app_id = message.data["droplet"].to_s

      logger.debug2("Filter message for app_id: %s" % app_id, app_id: app_id)
    Severity: Minor
    Found in lib/dea/starting/instance_registry.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        def promise_app_upload
      Promise.new do |p|
        logger.info('staging.droplet-upload.starting',
                    source: workspace.staged_droplet_path, destination: URICleaner.clean(staging_message.upload_uri))
    Severity: Major
    Found in lib/dea/staging/staging_task.rb and 1 other location - About 1 hr to fix
    lib/dea/staging/staging_task.rb on lines 360..375

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 67.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        def promise_buildpack_cache_upload
      Promise.new do |p|
        logger.info('staging.buildpack-cache-upload.starting',
                    source: workspace.staged_buildpack_cache_path, destination: URICleaner.clean(staging_message.buildpack_cache_upload_uri))
    Severity: Major
    Found in lib/dea/staging/staging_task.rb and 1 other location - About 1 hr to fix
    lib/dea/staging/staging_task.rb on lines 340..354

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 67.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method start has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

        def start
      staging_promise = Promise.new do |p|
        resolve_staging_setup
        resolve_staging
        p.deliver
    Severity: Minor
    Found in lib/dea/staging/staging_task.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method download! has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

      def download!(&blk)
    destination_file.binmode
    sha1 = Digest::SHA1.new

    http = EM::HttpRequest.new(source_uri, :inactivity_timeout => 30).get
    Severity: Minor
    Found in lib/dea/utils/download.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method promise_save_buildpack_cache has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        def promise_save_buildpack_cache
      Promise.new do |p|
        resolve_and_log(promise_pack_buildpack_cache, 'staging.buildpack-cache.save') do |error, _|
          unless error
            begin
    Severity: Minor
    Found in lib/dea/staging/staging_task.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method start has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def start(&callback)
      p = Promise.new do
        logger.info('droplet.starting')

        promise_state(State::BORN, State::STARTING).resolve
    Severity: Minor
    Found in lib/dea/starting/instance.rb - About 1 hr to fix

      Method resolve_staging_setup has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def resolve_staging_setup
      workspace.prepare(buildpack_manager)
      with_network = false

      stack = staging_message.stack
      Severity: Minor
      Found in lib/dea/staging/staging_task.rb - About 1 hr to fix

        Method generate has 32 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            def self.generate(bootstrap, instance, request)
      response = {
        "dea"             => bootstrap.uuid,
        "droplet"         => instance.application_id,
        "version"         => instance.application_version,
        Severity: Minor
        Found in lib/dea/protocol.rb - About 1 hr to fix

          Method handle_dea_stop has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

              def handle_dea_stop(message)
      if message.data.size == 1 && message.data['droplet']
        staging_stop_msg = Dea::Nats::Message.new(
          message.nats,
          'staging.stop',
          Severity: Minor
          Found in lib/dea/bootstrap.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method start has 31 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              def start
      staging_promise = Promise.new do |p|
        resolve_staging_setup
        resolve_staging
        p.deliver
          Severity: Minor
          Found in lib/dea/staging/staging_task.rb - About 1 hr to fix

            Method load has 30 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                def load
      return unless File.exist?(path)

      start = Time.now
            Severity: Minor
            Found in lib/dea/snapshot.rb - About 1 hr to fix

              Method upload! has 29 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                def upload!(&upload_callback)
    logger.info("em-upload.begin", destination: URICleaner.clean(@destination))

    SyncUpload.new(@source, @destination, @logger).upload! do |http, error|
      if error
              Severity: Minor
              Found in lib/dea/utils/upload.rb - About 1 hr to fix

                Method download_one_buildpack has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                Open

                  def download_one_buildpack(buildpack, dest_dir)
    Dea::Promise.new do |p|
      tmpfile = Tempfile.new('temp_admin_buildpack')

      Download.new(buildpack.fetch(:url), tmpfile, nil, logger).download! do |err|
                Severity: Minor
                Found in lib/dea/staging/admin_buildpack_downloader.rb - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method snapshot_attributes has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    def snapshot_attributes
      {
        'cc_partition' => attributes['cc_partition'],

        'instance_id' => attributes['instance_id'],
                Severity: Minor
                Found in lib/dea/starting/instance.rb - About 1 hr to fix

                  Method rule_args_for_protocol has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    def rule_args_for_protocol(protocol, rule)
    base_args = {
      handle:   container_handle,
      protocol: protocol,
      network:  rule['destination'],
                  Severity: Minor
                  Found in lib/dea/utils/egress_rules_mapper.rb - About 1 hr to fix

                    Method promise_stage has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        def promise_stage
      Promise.new do |p|
        script = staging_command
        logger.debug('staging.task.execute-staging')
                    Severity: Minor
                    Found in lib/dea/staging/staging_task.rb - About 1 hr to fix

                      Method initialize has 8 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                        def initialize(uuid, local_ip, message_bus, locator_responders, instance_registry, evac_handler, shutdown_handler, logger)
                      Severity: Major
                      Found in lib/dea/lifecycle/signal_handler.rb - About 1 hr to fix

                        Method download has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                        Open

                            def download(uri, &blk)
      if exists?
        blk.call(nil)
        return
      end
                        Severity: Minor
                        Found in lib/dea/droplet.rb - About 55 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Severity
                        Category
                        Status
                        Source
                        Language