Sign upLogin

cloudfoundry/health_manager

View on GitHub
Star
lib/health_manager/desired_state.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Method process_next_batch has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

    def process_next_batch(bulk_token, start_time, &block)
      with_credentials do |user, password|
        options = {
          :head => { 'authorization' => [user, password] },
          :query => {
Severity: Minor
Found in lib/health_manager/desired_state.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method process_next_batch has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def process_next_batch(bulk_token, start_time, &block)
      with_credentials do |user, password|
        options = {
          :head => { 'authorization' => [user, password] },
          :query => {
Severity: Minor
Found in lib/health_manager/desired_state.rb - About 1 hr to fix

    Method with_credentials has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def with_credentials
      if @user && @password
        yield @user, @password
      else
        logger.info("bulk: requesting API credentials over message bus...")
    Severity: Minor
    Found in lib/health_manager/desired_state.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method update_user_counts has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def update_user_counts
      with_credentials do |user, password|
        options = {
          :head => { 'authorization' => [user, password] },
          :query => { 'model' => 'user' }
    Severity: Minor
    Found in lib/health_manager/desired_state.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status