cloudfoundry/stratos

View on GitHub

Showing 718 of 1,370 total issues

Method PostgresCNSIRepository.UpdateMetadata has 5 return statements (exceeds 4 allowed).
Open

func (p *PostgresCNSIRepository) UpdateMetadata(guid string, metadata string) error {
    log.Debug("UpdateMetadata")

    if guid == "" {
        msg := "Unable to update Endpoint without a valid guid."
Severity: Major
Found in src/jetstream/repository/cnsis/pgsql_cnsis.go - About 35 mins to fix

    Method PgsqlTokenRepository.FindAuthToken has 5 return statements (exceeds 4 allowed).
    Open

    func (p *PgsqlTokenRepository) FindAuthToken(userGUID string, encryptionKey []byte) (interfaces.TokenRecord, error) {
        log.Debug("FindAuthToken")
        if userGUID == "" {
            msg := "Unable to find UAA Token without a valid User GUID."
            log.Debug(msg)
    Severity: Major
    Found in src/jetstream/repository/tokens/pgsql_tokens.go - About 35 mins to fix

      Function setupAutoSelectors has a Cognitive Complexity of 10 (exceeds 8 allowed). Consider refactoring.
      Open

        private setupAutoSelectors(initialCf: string, initialOrg: string) {
          // Clear or automatically select org + space given cf
          let cfTapped = false;
          const orgResetSub = this.cf.select.asObservable().pipe(
            startWith(initialCf),

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function addFile has a Cognitive Complexity of 10 (exceeds 8 allowed). Consider refactoring.
      Open

        addFile(file) {
          // Make the folder for the file
          const fileParts = file.webkitRelativePath.split('/');
          let context = this.root;
          let fullPath = '';

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function constructor has a Cognitive Complexity of 10 (exceeds 8 allowed). Consider refactoring.
      Open

        constructor(
          private store: Store<any>,
          private route: ActivatedRoute,
          router: Router,
          kubeId: BaseKubeGuid,

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function ngOnInit has a Cognitive Complexity of 10 (exceeds 8 allowed). Consider refactoring.
      Open

        ngOnInit() {
      
          const helmLastModifiedRegEx = /seconds:([0-9]*)/;
      
          this.sessionData$ = this.store.select(s => s.auth).pipe(

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function constructor has a Cognitive Complexity of 10 (exceeds 8 allowed). Consider refactoring.
      Open

        constructor(
          public endpointsService: EndpointsService,
          private store: Store<AppState>,
          public userFavoriteManager: UserFavoriteManager,
          private scrollDispatcher: ScrollDispatcher,
      Severity: Minor
      Found in src/frontend/packages/core/src/features/home/home/home-page.component.ts - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function canGoto has a Cognitive Complexity of 10 (exceeds 8 allowed). Consider refactoring.
      Open

        canGoto(index: number): boolean {
          if (index < 0 && this.basePreviousRedirect) {
            return true;
          }
          const step = this.steps[this.currentIndex];

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function applyRoutesFromExtensions has a Cognitive Complexity of 10 (exceeds 8 allowed). Consider refactoring.
      Open

        private applyRoutesFromExtensions(router: Router) {
          const routeConfig = [...router.config];
      
          // Find the route that has the 'about' page as a child - this is the dashboard base
          const dashboardRoute = routeConfig.find(r => {
      Severity: Minor
      Found in src/frontend/packages/core/src/core/extension/extension-service.ts - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function ngOnInit has a Cognitive Complexity of 10 (exceeds 8 allowed). Consider refactoring.
      Confirmed

        ngOnInit() {
          const events$ = this.eventService.events$.pipe(
            map(events => {
              if (this.endpointOnly) {
                return events.filter(event => event.key.split('-')[0] === 'endpointError');

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this function.
      Open

          return true;

        Avoid too many return statements within this function.
        Open

                    return appStateMatch[extState];

          Avoid too many return statements within this function.
          Open

              return true;
          Severity: Major
          Found in src/frontend/packages/devkit/src/lib/packages.ts - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                return false;

              Avoid too many return statements within this function.
              Open

                  return {
                    label: 'Unknown',
                    indicator: StratosStatus.ERROR,
                    actions: null
                  };

                Avoid too many return statements within this function.
                Open

                      return this.build(entityDefinition, entity, flatTree);
                Severity: Major
                Found in src/frontend/packages/store/src/helpers/schema-tree-traverse.ts - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                        return {
                          ...state,
                          pollingEnabled: pollingAction.enablePolling
                        };
                  Severity: Major
                  Found in src/frontend/packages/store/src/reducers/dashboard-reducer.ts - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                          return {
                            ...state,
                            ...hydrateDashboardStateAction.dashboardState
                          };
                    Severity: Major
                    Found in src/frontend/packages/store/src/reducers/dashboard-reducer.ts - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                          return false;

                        Avoid too many return statements within this function.
                        Open

                                return { ...state, isMobileNavOpen: !state.isMobileNavOpen };
                        Severity: Major
                        Found in src/frontend/packages/store/src/reducers/dashboard-reducer.ts - About 30 mins to fix
                          Severity
                          Category
                          Status
                          Source
                          Language