cloudfoundry/stratos

View on GitHub

Showing 1,155 of 1,370 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        endpoints: {
          cf: {
            '0e934dc8-7ad4-40ff-b85c-53c1b61d2abb': {
              global: {
                isAdmin: false,
src/frontend/packages/cloud-foundry/src/shared/services/current-user-permissions-and-cfchecker.service.spec.ts on lines 634..910

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 1059.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

File cf-entity-generator.ts has 1124 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { Compiler, Injector } from '@angular/core';
import { Action, Store } from '@ngrx/store';
import { entityFetchedWithoutError } from '@stratosui/store';
import { combineLatest, Observable, of } from 'rxjs';
import { first, map } from 'rxjs/operators';
Severity: Major
Found in src/frontend/packages/cloud-foundry/src/cf-entity-generator.ts - About 2 days to fix

    File list.component.ts has 649 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import { animate, style, transition, trigger } from '@angular/animations';
    import {
      AfterViewInit,
      ChangeDetectorRef,
      Component,

      Function constructor has 289 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        constructor() {
          const endpointDef: StratosEndpointExtensionDefinition = {
            type: KUBERNETES_ENDPOINT_TYPE,
            label: 'Kubernetes',
            labelPlural: 'Kubernetes',

        File main.go has 891 lines of code (exceeds 500 allowed). Consider refactoring.
        Open

        package main
        
        import (
            "crypto/sha1"
            "crypto/tls"
        Severity: Major
        Found in src/jetstream/main.go - About 1 day to fix

          File kubernetes-entity-generator.ts has 599 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          import { Compiler, Injector } from '@angular/core';
          import { Validators } from '@angular/forms';
          import moment from 'moment';
          
          import { BaseEndpointAuth } from '../../../core/src/core/endpoint-auth';

            Function initialise has 255 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              private initialise() {
                this.globalActions = this.setupActionsDefaultObservables(
                  this.config.getGlobalActions()
                );
                this.multiActions = this.setupActionsDefaultObservables(

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                    this.cardMenu = [
                      {
                        label: 'Edit',
                        action: this.edit,
                        can: this.currentUserPermissionsService.can(
              src/frontend/packages/cloud-foundry/src/shared/components/list/list-types/services-wall/user-provided-service-instance-card/user-provided-service-instance-card.component.ts on lines 56..85

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 230.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                  this.cardMenu = [
                    {
                      label: 'Edit',
                      action: this.edit,
                      can: this.currentUserPermissionsService.can(
              src/frontend/packages/cloud-foundry/src/shared/components/list/list-types/services-wall/service-instance-card/service-instance-card.component.ts on lines 52..81

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 230.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              File autoscaler.effects.ts has 528 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              import { HttpClient, HttpErrorResponse } from '@angular/common/http';
              import { Injectable } from '@angular/core';
              import { Actions, Effect, ofType } from '@ngrx/effects';
              import { Action, Store } from '@ngrx/store';
              import { Observable } from 'rxjs';
              Severity: Major
              Found in src/frontend/packages/cf-autoscaler/src/store/autoscaler.effects.ts - About 1 day to fix

                Method KubeTerminal.cleanup has a Cognitive Complexity of 58 (exceeds 8 allowed). Consider refactoring.
                Open

                func (k *KubeTerminal) cleanup() {
                    // Use a random initial wait before cleaning up
                    // If we had more than one backend, this helps to ensure they are not all trying to cleanup at the same time
                    wait := rand.Intn(30)
                    log.Debug("Kubernetes Terminal cleanup will start in %d minutes", wait)
                Severity: Minor
                Found in src/jetstream/plugins/kubernetes/terminal/cleanup.go - About 1 day to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                File kubernetes.effects.ts has 500 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                import { HttpClient, HttpHeaders, HttpParams } from '@angular/common/http';
                import { Injectable } from '@angular/core';
                import { Actions, Effect, ofType } from '@ngrx/effects';
                import { Action, Store } from '@ngrx/store';
                import { ClearPaginationOfEntity, ClearPaginationOfType } from 'frontend/packages/store/src/actions/pagination.actions';

                  File kube.types.ts has 499 lines of code (exceeds 250 allowed). Consider refactoring.
                  Open

                  import { Observable } from 'rxjs';
                  
                  import {
                    OrchestratedActionBuilderConfig,
                    OrchestratedActionBuilders,
                  Severity: Minor
                  Found in src/frontend/packages/kubernetes/src/kubernetes/store/kube.types.ts - About 1 day to fix

                    File autoscaler-transform-metric.spec.ts has 487 lines of code (exceeds 250 allowed). Consider refactoring.
                    Open

                    import {
                      isEqual
                    } from './autoscaler-util';
                    import {
                      insertEmptyMetrics, buildMetricData

                      Function setupCfUserRemovalTests has 189 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                      export function setupCfUserRemovalTests(
                        cfLevel: CfUserRemovalTestLevel,
                        removalLevel: CfRolesRemovalLevel,
                        navToUserTableFn: (cfGuid: string, orgGuid: string, spaceGuid: string) => promise.Promise<any>
                      ) {
                      Severity: Major
                      Found in src/test-e2e/cloud-foundry/users-removal-e2e.helper.ts - About 7 hrs to fix

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                            it('Borked, usually due to platform issues (2)', () => {
                              let testData = makeTestData('STARTED', 'STAGED', ['RUNNING', 'UNKNOWN']);
                              let res = cfAppStateService.get(testData.summary, testData.instances);
                              expect(res.indicator).toBe('warning');
                              expect($translate.instant(res.label)).toBe('Deployed');
                        src/frontend/packages/cloud-foundry/src/shared/services/application-state.service.spec.ts on lines 204..220

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 341.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                            it('Borked, usually due to platform issues', () => {
                              let testData = makeTestData('STARTED', 'STAGED', ['RUNNING', 'CRASHED']);
                              let res = cfAppStateService.get(testData.summary, testData.instances);
                              expect(res.indicator).toBe('warning');
                              expect($translate.instant(res.label)).toBe('Deployed');
                        src/frontend/packages/cloud-foundry/src/shared/services/application-state.service.spec.ts on lines 222..238

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 341.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Function processArray has a Cognitive Complexity of 51 (exceeds 8 allowed). Consider refactoring.
                        Open

                        function processArray(array, output?, nested?: boolean) {
                          let format;
                          let oneOf;
                          let type;
                        
                        

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function setupInviteUserTests has 181 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                        export function setupInviteUserTests(
                          isSpace: boolean,
                          navToOrgSpaceUsersList: (cfHelper: CFHelpers, defaultCf: E2EConfigCloudFoundry) => promise.Promise<any>,
                          navToCfSummary: () => promise.Promise<any>
                        ) {
                        Severity: Major
                        Found in src/test-e2e/cloud-foundry/invite-users-e2e.helper.ts - About 7 hrs to fix

                          File entity-relations-validate.spec.ts has 464 lines of code (exceeds 250 allowed). Consider refactoring.
                          Open

                          import { inject, TestBed } from '@angular/core/testing';
                          import { Store } from '@ngrx/store';
                          import { createBasicStoreModule, createEntityStoreState, TestStoreEntity } from '@stratosui/store/testing';
                          
                          import { environment } from '../../../core/src/environments/environment';
                            Severity
                            Category
                            Status
                            Source
                            Language