cloudfoundry/stratos

View on GitHub

Showing 718 of 1,370 total issues

Function MigrateSetupData has 15 return statements (exceeds 4 allowed).
Open

func MigrateSetupData(portal interfaces.PortalProxy, configStore Repository) error {

    // Determine if we need to migrate data first
    _, ok, err := configStore.GetValue(systemGroupName, configSetupNeededMarker)
    if err != nil {
Severity: Major
Found in src/jetstream/repository/console_config/env_lookup.go - About 1 hr to fix

    Function getYDomainLine has a Cognitive Complexity of 15 (exceeds 8 allowed). Consider refactoring.
    Open

      getYDomainLine(): any[] {
        const domain = [];
    
        for (const results of this.lineChart) {
          for (const d of results.series) {

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function parseAuth has a Cognitive Complexity of 15 (exceeds 8 allowed). Consider refactoring.
    Open

      public parseAuth(cluster: KubeConfigFileCluster, user: KubeConfigFileUser): RowState {
    
        // Default subtype is generic Kubernetes ('') or previously determined/selected sub type
        cluster._subType = cluster._subType || '';
    
    

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function ngOnInit has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      ngOnInit() {
        this.addOrg = new FormGroup({
          orgName: new FormControl('', [Validators.required as any, this.nameTakenValidator()]),
          quotaDefinition: new FormControl(),
        });

      Function ngOnInit has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        ngOnInit() {
          this.appSub$ = this.applicationService.entityService.entityMonitor.entityRequest$.subscribe(requestInfo => {
            if (
              requestInfo.deleting.deleted ||
              requestInfo.error

        Function apply has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          private apply(response) {
            if (response) {
              // In order to supplement the sanitizers with extra properties need to create new obj (see spread below and `reduce`)
              response = {
                ...response,

          Function userFavoriteGroupsReducer has 35 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          export function userFavoriteGroupsReducer(
            state: IUserFavoritesGroupsState = getDefaultFavoriteGroupsState(),
            action: Action
          ): IUserFavoritesGroupsState {
            switch (action.type) {

            Method UserInvite.UAAUserInvite has 59 lines of code (exceeds 50 allowed). Consider refactoring.
            Open

            func (invite *UserInvite) UAAUserInvite(c echo.Context, endpoint interfaces.CNSIRecord, uaaInviteReq *UserInviteReq) (*UserInviteResponse, error) {
                log.Debug("Requesting invite links from UAA")
            
                // See if we can get a token for the invite user
                token, ok := invite.portalProxy.GetCNSITokenRecord(endpoint.GUID, UserInviteUserID)
            Severity: Minor
            Found in src/jetstream/plugins/userinvite/invite.go - About 1 hr to fix

              Method Analysis.checkStatus has 59 lines of code (exceeds 50 allowed). Consider refactoring.
              Open

              func (c *Analysis) checkStatus() error {
                  log.Debug("Checking status....")
                  p := c.portalProxy
                  // Create a record in the reports datastore
                  dbStore, err := store.NewAnalysisDBStore(p.GetDatabaseConnection())
              Severity: Minor
              Found in src/jetstream/plugins/analysis/status.go - About 1 hr to fix

                Function constructor has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  constructor(
                    store: Store<CFAppState>,
                    datePipe: DatePipe,
                    scmService: GitSCMService
                  ) {

                  Function waitForRow has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                        function waitForRow() {
                          // Timeout after 32 attempts (each 5 seconds, which is just under 3 minutes)
                          let retries = 32;
                          const sub = timer(5000, 5000).pipe(
                            switchMap(() => promise.all<boolean | number | TableData[]>([
                  Severity: Minor
                  Found in src/test-e2e/application/application-autoscaler-e2e.spec.ts - About 1 hr to fix

                    Function autoscalerTransformMapToArray has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                    export function autoscalerTransformMapToArray(oldPolicy: AppAutoscalerPolicyLocal) {
                      const newPolicy: AppAutoscalerPolicy = {
                        instance_min_count: oldPolicy.instance_min_count,
                        instance_max_count: oldPolicy.instance_max_count
                      };

                      Method PgsqlTokenRepository.UpdateTokenAuth has 59 lines of code (exceeds 50 allowed). Consider refactoring.
                      Open

                      func (p *PgsqlTokenRepository) UpdateTokenAuth(userGUID string, tr interfaces.TokenRecord, encryptionKey []byte) error {
                          log.Debug("UpdateTokenAuth")
                      
                          if userGUID == "" {
                              msg := "Unable to save Token without a valid User GUID."
                      Severity: Minor
                      Found in src/jetstream/repository/tokens/pgsql_tokens.go - About 1 hr to fix

                        Function constructAmalgamatedObservables has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                          private constructAmalgamatedObservables() {
                            // Assign/Amalgamate them to public properties (with mangling if required)
                            const appStats = cfEntityCatalog.appStats.store.getPaginationService(this.appGuid, this.cfGuid);
                            // This will fail to fetch the app stats if the current app is not running but we're
                            // willing to do this to speed up the initial fetch for a running application.

                          Function generateCfOrgEntity has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                          function generateCfOrgEntity(endpointDefinition: StratosEndpointExtensionDefinition) {
                            const orgDefinition: IStratosEntityDefinition = {
                              type: organizationEntityType,
                              schema: cfEntityFactory(organizationEntityType),
                              label: 'Organization',
                          Severity: Minor
                          Found in src/frontend/packages/cloud-foundry/src/cf-entity-generator.ts - About 1 hr to fix

                            Function constructor has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                              constructor(
                                store: Store<CFAppState>,
                                appService: ApplicationService,
                                datePipe: DatePipe,
                                currentUserPermissionService: CurrentUserPermissionsService,

                              Function getPaginationUpdater has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                              Open

                              const getPaginationUpdater = (types: [string, string, string]) => {
                                const [requestType, successType, failureType] = types;
                                return (state: PaginationEntityState = getDefaultPaginationEntityState(), action): PaginationEntityState => {
                                  switch (action.type) {
                                    case requestType:

                                Function canActivate has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                                Open

                                  canActivate(route: ActivatedRouteSnapshot, routeState: RouterStateSnapshot): Observable<boolean> {
                                    // Reroute user to endpoint/no endpoint screens if there are no connected or registered endpoints
                                    return observableCombineLatest(
                                      this.store.select('auth'),
                                      this.store.select(endpointStatusSelector)
                                Severity: Minor
                                Found in src/frontend/packages/core/src/core/endpoints.service.ts - About 1 hr to fix

                                  Function setActive has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                                  Open

                                    setActive(index: number) {
                                      if (this.basePreviousRedirect && index < 0) {
                                        this.dispatchRedirect(this.basePreviousRedirect);
                                      }
                                      if (!this.canGoto(index)) {

                                    Function ngOnInit has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                                    Confirmed

                                      ngOnInit() {
                                        if (!this.connectionStatus) {
                                          return;
                                        }
                                    
                                    
                                      Severity
                                      Category
                                      Status
                                      Source
                                      Language