cloudfoundry/stratos

View on GitHub

Showing 718 of 1,370 total issues

Function isNewer has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  public isNewer(other: Version): boolean {
    if (!this.valid || !other.valid) {
      return false;
    }

    Function generateJsonSchemaFromObject has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export function generateJsonSchemaFromObject(title, object) {
      let processOutput;
      const output: any = {
        $schema: DRAFT
      };

      Function constructor has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        constructor(
          private activatedRoute: ActivatedRoute,
          private metricsService: MetricsService,
          private store: Store<AppState>,
        ) {

        Function makeSpan has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          makeSpan() {
            let span = '';
            if (this.boldOn || this.currentFg || this.currentBg) {
              span += '<span class="';
              if (this.boldOn) {

          Function fillOutTimeOrderedChartSeries has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            static fillOutTimeOrderedChartSeries(
              timeOrdered: ChartSeries[],
              start: number,
              end: number,
              step: number,

            Function ngOnInit has 27 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              ngOnInit() {
                if (this.rowState) {
                  this.inErrorState$ = this.rowState.pipe(
                    map(state => state.error)
                  );

              Method UaaUserInfo.uaa has 51 lines of code (exceeds 50 allowed). Consider refactoring.
              Open

              func (userInfo *UaaUserInfo) uaa(target string, body []byte) (int, []byte, *http.Header, error) {
                  log.Debug("uaa request")
              
                  // Check session
                  _, err := userInfo.portalProxy.GetSessionInt64Value(userInfo.echo, "exp")
              Severity: Minor
              Found in src/jetstream/plugins/userinfo/uaa_user.go - About 1 hr to fix

                Method KubeTerminal.cleanup has 51 lines of code (exceeds 50 allowed). Consider refactoring.
                Open

                func (k *KubeTerminal) cleanup() {
                    // Use a random initial wait before cleaning up
                    // If we had more than one backend, this helps to ensure they are not all trying to cleanup at the same time
                    wait := rand.Intn(30)
                    log.Debug("Kubernetes Terminal cleanup will start in %d minutes", wait)
                Severity: Minor
                Found in src/jetstream/plugins/kubernetes/terminal/cleanup.go - About 1 hr to fix

                  Method PgsqlTokenRepository.SaveAuthToken has 51 lines of code (exceeds 50 allowed). Consider refactoring.
                  Open

                  func (p *PgsqlTokenRepository) SaveAuthToken(userGUID string, tr interfaces.TokenRecord, encryptionKey []byte) error {
                      log.Debug("SaveAuthToken")
                      if userGUID == "" {
                          msg := "Unable to save Auth Token without a valid User GUID."
                          log.Debug(msg)
                  Severity: Minor
                  Found in src/jetstream/repository/tokens/pgsql_tokens.go - About 1 hr to fix

                    Function autoscalerTransformArrayToMap has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                    export function autoscalerTransformArrayToMap(policy: AppAutoscalerPolicy) {
                      const newPolicy: AppAutoscalerPolicyLocal = {
                        ...policy,
                        enabled: true,
                        scaling_rules_map: {},

                      Function constructor has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                        constructor(
                          store: Store<CFAppState>,
                          cfGuid: string,
                          cellId: string,
                          listConfig: IListConfig<CfCellApp>,

                        Function createCf has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                          private createCf() {
                            const list$ = this.store.select(connectedEndpointsOfTypesSelector(CF_ENDPOINT_TYPE)).pipe(
                              // Ensure we have endpoints
                              filter(endpoints => endpoints && !!Object.keys(endpoints).length),
                              publishReplay(1),

                          Function setUpManager has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                            private static setUpManager(
                              paginationMonitor: PaginationMonitor<APIResource>,
                              rowStateManager: TableRowStateManager
                            ) {
                              return paginationMonitor.currentPage$.pipe(

                            Function getSpacePermissions has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                              private getSpacePermissions(spacePerms: IUserPermissionInSpace, row: APIResource<CfUser>, isOrgLevel = true) {
                                return getSpaceRoles(spacePerms.permissions).map(perm => {
                                  const updatingKey = RemoveCfUserRole.generateUpdatingKey(
                                    perm.key,
                                    row.metadata.guid

                              Function createChangesObs has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                              Open

                                private createChangesObs() {
                                  const changesViaUsername = this.updateChanges.pipe(
                                    switchMap(() => this.store.select(selectCfUsersRolesChangedRoles)),
                                    map(changes => changes
                                      .map(change => ({

                                Function updateAppSummaryRoutesReducer has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                                Open

                                export function updateAppSummaryRoutesReducer(state: IRequestEntityTypeState<IAppSummary>, action: APISuccessOrFailedAction) {
                                  let currentState;
                                  let routeGuid;
                                  switch (action.type) {
                                    case RouteEvents.UNMAP_ROUTE_SUCCESS:

                                  Function constructor has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                                  Open

                                    constructor(
                                      protected store: Store<CFAppState>,
                                      protected activatedRoute: ActivatedRoute,
                                      protected activeRouteCfOrgSpace: ActiveRouteCfOrgSpace,
                                    ) {

                                    Function constructor has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                                    Open

                                      constructor(
                                        public cfEndpointService: CloudFoundryEndpointService,
                                        public cfSpaceService: CloudFoundrySpaceService,
                                        public cfOrgService: CloudFoundryOrganizationService,
                                        private store: Store<CFAppState>,

                                      Function createRolesUserDiff has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                                      Open

                                        private createRolesUserDiff(
                                          existingRoles: CfUserRolesSelected,
                                          newRoles: IUserPermissionInOrg,
                                          changes: CfRoleChange[],
                                          user: CfUser,

                                        Function getEntities has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                                        Open

                                        function getEntities(
                                          endpointResponse: {
                                            normalizedEntities: NormalizedResponse<any>;
                                            endpointGuid: string;
                                          },
                                          Severity
                                          Category
                                          Status
                                          Source
                                          Language