cloudfoundry/stratos

View on GitHub

Showing 718 of 1,370 total issues

Function KubeDashboardLogin has a Cognitive Complexity of 11 (exceeds 8 allowed). Consider refactoring.
Open

func KubeDashboardLogin(c echo.Context, p interfaces.PortalProxy) error {
    log.Debug("kubeDashboardLogin request")

    endpointGUID := c.Param("guid")
    userGUID := c.Get("user_id").(string)
Severity: Minor
Found in src/jetstream/plugins/kubernetes/dashboard/login.go - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function NewDatabaseConnectionParametersFromConfig has 7 return statements (exceeds 4 allowed).
Open

func NewDatabaseConnectionParametersFromConfig(dc DatabaseConfig) (DatabaseConfig, error) {

    if len(dc.DatabaseProvider) == 0 {
        dc.DatabaseProvider = DefaultDatabaseProvider
    }
Severity: Major
Found in src/jetstream/datastore/datastore.go - About 45 mins to fix

    Function init has a Cognitive Complexity of 11 (exceeds 8 allowed). Consider refactoring.
    Open

    func init() {
        RegisterMigration(20180413135700, "MetricsSchema", func(txn *sql.Tx, conf *goose.DBConf) error {
            if strings.Contains(conf.Driver.Name, "sqlite3") {
                // SQLite does not support MODIFY on ALTER TABLE - but fortunately it doesn't mind about the column sizes
                return nil
    Severity: Minor
    Found in src/jetstream/datastore/20180413135700_MetricsSchema.go - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid deeply nested control flow statements.
    Open

                        if strings.HasPrefix(authToken, "bearer ") {
                            authToken = authToken[7:]
                        }
    Severity: Major
    Found in src/jetstream/plugins/desktop/tokens.go - About 45 mins to fix

      Function updateCFFIle has 7 return statements (exceeds 4 allowed).
      Open

      func updateCFFIle(updates map[string]string) error {
          usr, err := user.Current()
          if err != nil {
              return err
          }
      Severity: Major
      Found in src/jetstream/plugins/desktop/cloudfoundry.go - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                            if err != nil {
                                return fmt.Errorf("Can not get endpoint type for %s: '%v'", endpoint.CNSIType, err)
                            }
        Severity: Major
        Found in src/jetstream/cnsi.go - About 45 mins to fix

          Method PgsqlTokenRepository.SaveAuthToken has 7 return statements (exceeds 4 allowed).
          Open

          func (p *PgsqlTokenRepository) SaveAuthToken(userGUID string, tr interfaces.TokenRecord, encryptionKey []byte) error {
              log.Debug("SaveAuthToken")
              if userGUID == "" {
                  msg := "Unable to save Auth Token without a valid User GUID."
                  log.Debug(msg)
          Severity: Major
          Found in src/jetstream/repository/tokens/pgsql_tokens.go - About 45 mins to fix

            Method PgsqlTokenRepository.findCNSIToken has 7 return statements (exceeds 4 allowed).
            Open

            func (p *PgsqlTokenRepository) findCNSIToken(cnsiGUID string, userGUID string, encryptionKey []byte, includeDisconnected bool) (interfaces.TokenRecord, error) {
                log.Debug("findCNSIToken")
                if cnsiGUID == "" {
                    msg := "Unable to find CNSI Token without a valid CNSI GUID."
                    log.Debug(msg)
            Severity: Major
            Found in src/jetstream/repository/tokens/pgsql_tokens.go - About 45 mins to fix

              Function updateUser has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                apiUsers: IRequestEntityTypeState<APIResource<CfUser>>,
                existingUsers: IRequestEntityTypeState<APIResource<CfUser>>,
                newUsers: IRequestEntityTypeState<APIResource<CfUser>>,
                orgOrSpace,
                orgSpaceParamName: string,

                Function constructor has a Cognitive Complexity of 11 (exceeds 8 allowed). Consider refactoring.
                Open

                  constructor(dir: string, options?: any, loggingEnabled = true) {
                    this.angularJsonFile = this.findFileOrFolderInChain(dir, 'angular.json');
                    this.angularJson = JSON.parse(fs.readFileSync(this.angularJsonFile, 'utf8').toString());
                    this.loggingEnabled = loggingEnabled;
                
                
                Severity: Minor
                Found in src/frontend/packages/devkit/src/lib/stratos.config.ts - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Avoid deeply nested control flow statements.
                Open

                            if (scExtState) {
                              extState = scExtState;
                            } else {
                              extState = pkgState + '(' +
                                this.formatCount(counts.running) + ',' +

                  Function constructor has a Cognitive Complexity of 11 (exceeds 8 allowed). Consider refactoring.
                  Open

                    constructor(
                      private store: Store<CFAppState>,
                      private activeRouteCfOrgSpace: ActiveRouteCfOrgSpace,
                      private cfUserService: CfUserService,
                      private route: ActivatedRoute

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function apply has a Cognitive Complexity of 11 (exceeds 8 allowed). Consider refactoring.
                  Open

                    public apply(src: string): string {
                  
                      // Patch different page title if there is one
                      const title = this.config.stratosConfig.title || 'Stratos';
                      src = src.replace(/@@TITLE@@/g, title);
                  Severity: Minor
                  Found in src/frontend/packages/devkit/src/build/index.transform.ts - About 45 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function successEntityHandler has 6 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                    actionDispatcher: (actionToDispatch: Action) => void,
                    catalogEntity: StratosBaseCatalogEntity,
                    requestType: ApiRequestTypes,
                    action: EntityRequestAction,
                    result: PipelineResult,

                    Function succeedRequest has a Cognitive Complexity of 11 (exceeds 8 allowed). Consider refactoring.
                    Open

                    export function succeedRequest(state: BaseRequestState, action: ISuccessRequestAction) {
                      if (!isNullOrUndefined(action.apiAction.guid)) {
                        const apiAction = action.apiAction as BaseEntityRequestAction;
                        const successAction = action as WrapperRequestActionSuccess;
                        const requestSuccessState = getEntityRequestState(state, apiAction);

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function failedEntityHandler has 6 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                      actionDispatcher: ActionDispatcher,
                      catalogEntity: StratosBaseCatalogEntity,
                      requestType: ApiRequestTypes,
                      action: EntityRequestAction,
                      response: PipelineResult,

                      Function getObservables has 6 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                        store: Store<GeneralEntityAppState>,
                        entityKey: string,
                        paginationKey: string,
                        paginationAction: PaginatedAction | PaginatedAction[],
                        paginationMonitor: PaginationMonitor,

                        Function failApiRequest has 6 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                          store: Store<T>,
                          apiAction: EntityRequestAction,
                          error,
                          catalogEntity: StratosBaseCatalogEntity,
                          requestType: ApiRequestTypes = 'fetch',

                          Function editModeChanged has a Cognitive Complexity of 11 (exceeds 8 allowed). Consider refactoring.
                          Open

                            editModeChanged(mode) {
                              this.mode = mode.value;
                          
                              if (this.mode === EditorMode.CodeEditor) {
                                // Form -> Editor

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function successEntityHandler has a Cognitive Complexity of 11 (exceeds 8 allowed). Consider refactoring.
                          Open

                          export function successEntityHandler(
                            actionDispatcher: (actionToDispatch: Action) => void,
                            catalogEntity: StratosBaseCatalogEntity,
                            requestType: ApiRequestTypes,
                            action: EntityRequestAction,

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Severity
                          Category
                          Status
                          Source
                          Language