cloudfoundry/warden

View on GitHub
warden-client/lib/warden/client/v1.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Class V1 has 35 methods (exceeds 20 allowed). Consider refactoring.
Open

    class V1
      def self.request_from_v1(args)
        command = args.shift

        m = "convert_#{command}_request".downcase
Severity: Minor
Found in warden-client/lib/warden/client/v1.rb - About 4 hrs to fix

    Method convert_limit_request has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

          def self.convert_limit_request(args)
            request = nil
            handle  = args.shift
            limit   = args.shift
    
    
    Severity: Minor
    Found in warden-client/lib/warden/client/v1.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method convert_create_request has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

          def self.convert_create_request(args)
            request = Protocol::CreateRequest.new
            config = args.shift || {}
    
            config.each do |key, value|
    Severity: Minor
    Found in warden-client/lib/warden/client/v1.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status