Sign upLogin

cloudfoundry/warden

View on GitHub
Star
warden/lib/warden/container/features/net.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method do_net_out has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

        def do_net_out(request, response)
          unless request.network || request.port || request.port_range
            raise WardenError.new("Please specify network, port, and/or port_range.")
          end
Severity: Minor
Found in warden/lib/warden/container/features/net.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method do_net_in has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

        def do_net_in(request, response)
          if request.host_port.nil?
            host_port = self.class.port_pool.acquire

            # Use same port on the container side as the host side if unspecified
Severity: Minor
Found in warden/lib/warden/container/features/net.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method _net_out has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

        def _net_out(network, port_range, protocol, icmp_type, icmp_code, log)
Severity: Minor
Found in warden/lib/warden/container/features/net.rb - About 45 mins to fix

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

            def acquire(opts = {})
          if !@resources.has_key?("ports")
            @resources["ports"] = []
            @acquired["ports"] = []
          else
    Severity: Minor
    Found in warden/lib/warden/container/features/net.rb and 1 other location - About 15 mins to fix
    warden/lib/warden/container/insecure.rb on lines 69..78

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 26.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status