Sign upLogin

cloudfoundry/warden

View on GitHub
Star
warden/lib/warden/container/job.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method stream has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

        def stream(&block)
          # Handle the case where we are restarted after the job has completed.
          # In this situation there will be no child, hence no stream listeners.
          if terminated?
            exit_status, stdout, stderr = @snapshot["status"]
Severity: Minor
Found in warden/lib/warden/container/job.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method run has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def run(options = {})
          discard_output = @snapshot.fetch("discard_output", options[:discard_output])
          syslog_tag = @snapshot.fetch("log_tag", options[:log_tag])

          syslog_socket = options[:syslog_socket]
Severity: Minor
Found in warden/lib/warden/container/job.rb - About 1 hr to fix

    Method run has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

            def run(options = {})
          discard_output = @snapshot.fetch("discard_output", options[:discard_output])
          syslog_tag = @snapshot.fetch("log_tag", options[:log_tag])

          syslog_socket = options[:syslog_socket]
    Severity: Minor
    Found in warden/lib/warden/container/job.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status