Sign upLogin

cloudfoundry/warden

View on GitHub
Star
warden/lib/warden/repl/commands_manager.rb

Summary

Maintainability
D
2 days
Test Coverage

File commands_manager.rb has 374 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require "warden/protocol"
require "forwardable"

module Warden::Repl
  module CommandsManager
Severity: Minor
Found in warden/lib/warden/repl/commands_manager.rb - About 5 hrs to fix

    Method populate_request has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
    Open

        def populate_request(request, arguments, field_delim = ".")
      # Handle to the proto buf object that will be populated with a value.
      pb_handle = nil
      # Name of field and its type to be populated into pb_handle.
      last_parsed = {}
    Severity: Minor
    Found in warden/lib/warden/repl/commands_manager.rb - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method do_generate_help has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
    Open

        def do_generate_help(cmd_type, opts = {})
      help = {}
      help[:description] = command_descriptions[to_type(cmd_type)]

      help_generator = lambda do |field, prefix|
    Severity: Minor
    Found in warden/lib/warden/repl/commands_manager.rb - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method populate_request has 77 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def populate_request(request, arguments, field_delim = ".")
      # Handle to the proto buf object that will be populated with a value.
      pb_handle = nil
      # Name of field and its type to be populated into pb_handle.
      last_parsed = {}
    Severity: Major
    Found in warden/lib/warden/repl/commands_manager.rb - About 3 hrs to fix

      Method do_serialize has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
      Open

          def do_serialize(obj, field_delim = ".")
      return obj.to_s if !obj.is_a?(Warden::Protocol::BaseMessage)

      append_serialized = lambda do |key, source, target_hash, field_delim|
        if source.is_a?(Hash)
      Severity: Minor
      Found in warden/lib/warden/repl/commands_manager.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method do_generate_help has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def do_generate_help(cmd_type, opts = {})
      help = {}
      help[:description] = command_descriptions[to_type(cmd_type)]

      help_generator = lambda do |field, prefix|
      Severity: Minor
      Found in warden/lib/warden/repl/commands_manager.rb - About 1 hr to fix

        Method do_serialize has 36 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            def do_serialize(obj, field_delim = ".")
      return obj.to_s if !obj.is_a?(Warden::Protocol::BaseMessage)

      append_serialized = lambda do |key, source, target_hash, field_delim|
        if source.is_a?(Hash)
        Severity: Minor
        Found in warden/lib/warden/repl/commands_manager.rb - About 1 hr to fix

          Method deserialize has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              def deserialize(command_args, field_delim = ".")
      if command_args.empty?
        raise ArgumentError, "Command arguments should be non-empty."
      end
          Severity: Minor
          Found in warden/lib/warden/repl/commands_manager.rb - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      if protobuf_field?(field)
              pb_handle = initialize_pb(list, element, field.type)
              fields = get_fields_map(pb_handle)
              # Clear last_parsed to catch erroneous command-line flags.
              last_parsed.clear
          Severity: Minor
          Found in warden/lib/warden/repl/commands_manager.rb and 1 other location - About 15 mins to fix
          warden/lib/warden/repl/commands_manager.rb on lines 492..499

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 25.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      if protobuf_field?(field)
              pb_handle = initialize_nested_pb(pb_handle, element, field.type)
              fields = get_fields_map(pb_handle)
              # Clear last_parsed to catch erroneous command-line flags.
              last_parsed.clear
          Severity: Minor
          Found in warden/lib/warden/repl/commands_manager.rb and 1 other location - About 15 mins to fix
          warden/lib/warden/repl/commands_manager.rb on lines 482..489

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 25.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status