Sign upLogin

cloudmatrix/esky

View on GitHub
Star
esky/bdist_esky/pypy_winres.py

Summary

Maintainability
A
1 hr
Test Coverage

Function load_resource_pystr has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

def load_resource_pystr(py,filename,resname,resid,reslang):
Severity: Minor
Found in esky/bdist_esky/pypy_winres.py - About 35 mins to fix

    Function load_resource_pystr has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    def load_resource_pystr(py,filename,resname,resid,reslang):
    """Load the named resource from the given file as a python-level string

    The filename and resource name must be ascii strings, and the resid and
    reslang must be integers.
    Severity: Minor
    Found in esky/bdist_esky/pypy_winres.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function load_resource has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    def load_resource(filename,resname,resid,reslang):
    """Load the named resource from the given file.

    The filename and resource name must be ascii strings, and the resid and
    reslang must be integers.
    Severity: Minor
    Found in esky/bdist_esky/pypy_winres.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status