Sign upLogin

cloudpassage/connector

View on GitHub
Star

Showing 69 of 69 total issues

Function retrieve_events has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def retrieve_events(self):
        """retrieve events"""
        end_date = self.initial_date()
        event_type = self.args["eventtype"]
        initial_event_id = self.latest_event("1", "", "1",event_type)["events"][0]["id"]
Severity: Minor
Found in lib/event.py - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

        original = os.path.join(self.args["configdir"], "issues$%s$%s" % (self.key_id, initial_date))  # NOQA
Severity: Major
Found in lib/issue.py and 3 other locations - About 35 mins to fix
lib/event.py on lines 163..163
lib/event.py on lines 164..164
lib/issue.py on lines 161..161

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

        new = os.path.join(self.args["configdir"], "%s_%s" % (self.key_id, end_date))  # NOQA
Severity: Major
Found in lib/event.py and 3 other locations - About 35 mins to fix
lib/event.py on lines 163..163
lib/issue.py on lines 160..160
lib/issue.py on lines 161..161

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

        new = os.path.join(self.args["configdir"], "issues$%s$%s" % (self.key_id, end_date))  # NOQA
Severity: Major
Found in lib/issue.py and 3 other locations - About 35 mins to fix
lib/event.py on lines 163..163
lib/event.py on lines 164..164
lib/issue.py on lines 160..160

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

        original = os.path.join(self.args["configdir"], "%s_%s" % (self.key_id, initial_date))  # NOQA
Severity: Major
Found in lib/event.py and 3 other locations - About 35 mins to fix
lib/event.py on lines 164..164
lib/issue.py on lines 160..160
lib/issue.py on lines 161..161

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function issues_check_starting has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def issues_check_starting(self):
        """determine starting date"""
        if self.options["issues_starting"] and self.options["configdir"] is None:
            validate.starting(self.options["issues_starting"])
            return self.options["issues_starting"]
Severity: Minor
Found in lib/utility.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

                return self.options["starting"]
Severity: Major
Found in lib/utility.py - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

                    return self.options["issues_starting"]
    Severity: Major
    Found in lib/utility.py - About 30 mins to fix

      Function build_leef_mapping has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def build_leef_mapping(self, event):
        """Set fields in LEEF event mapping."""
        mapping = {}
        self.build_leef_outliers(mapping, event)
        for key, value in self.event_reference['leefFieldMapping'].items():
      Severity: Minor
      Found in lib/leef.py - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language