Sign upLogin

cloudspokes/cs-website-cms

View on GitHub
Star
lib/redis/challenge_searchable.rb

Summary

Maintainability
C
1 day
Test Coverage

Method redis_insert has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def redis_insert
    Rails.logger.info "[REDIS] Inserting challenge #{challenge_id}"
    nest[:raw_data].hset challenge_id, raw_data.to_json

    redis_metaphones.each do |meta|
Severity: Minor
Found in lib/redis/challenge_searchable.rb - About 1 hr to fix

    Method redis_key_for_prize_money has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def redis_key_for_prize_money(value)
      if value.is_a?(Hash)
        min = value[:min].blank? ? 0 : value[:min].to_i
        max = value[:max].blank? ? 1000000 : value[:max].to_i
        nest[:temp][{prize_money: value}.hash].tap do |k|
    Severity: Minor
    Found in lib/redis/challenge_searchable.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method redis_key_for_participants has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def redis_key_for_participants(value)
      if value.is_a?(Hash)
        min = value[:min].blank? ? 0 : value[:min].to_i
        max = value[:max].blank? ? 1000 : value[:max].to_i
        nest[:temp][{participants: value}.hash].tap do |k|
    Severity: Minor
    Found in lib/redis/challenge_searchable.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method redis_sorted_ids has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def redis_sorted_ids(set_key, options = {})
      if options[:sort_by]
        sort_options = {}
        sort_options[:by] = nest[:sort][options[:sort_by]]['*']
        order = []
    Severity: Minor
    Found in lib/redis/challenge_searchable.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        def redis_key_for_participants(value)
      if value.is_a?(Hash)
        min = value[:min].blank? ? 0 : value[:min].to_i
        max = value[:max].blank? ? 1000 : value[:max].to_i
        nest[:temp][{participants: value}.hash].tap do |k|
    Severity: Major
    Found in lib/redis/challenge_searchable.rb and 1 other location - About 1 hr to fix
    lib/redis/challenge_searchable.rb on lines 75..84

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 60.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        def redis_key_for_prize_money(value)
      if value.is_a?(Hash)
        min = value[:min].blank? ? 0 : value[:min].to_i
        max = value[:max].blank? ? 1000000 : value[:max].to_i
        nest[:temp][{prize_money: value}.hash].tap do |k|
    Severity: Major
    Found in lib/redis/challenge_searchable.rb and 1 other location - About 1 hr to fix
    lib/redis/challenge_searchable.rb on lines 88..97

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 60.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        def redis_key_for_technologies(technologies)
      keys = technologies.map {|t| nest[:technologies][t]}.compact

      if keys.length > 1
        nest[:temp][{technologies: technologies}.hash].tap do |k|
    Severity: Minor
    Found in lib/redis/challenge_searchable.rb and 2 other locations - About 35 mins to fix
    lib/redis/challenge_searchable.rb on lines 120..128
    lib/redis/challenge_searchable.rb on lines 132..140

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 35.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        def redis_key_for_categories(categories)
      keys = categories.map {|cat| nest[:categories][cat]}.compact

      if keys.length > 1
        nest[:temp][{categories: categories}.hash].tap do |k|
    Severity: Minor
    Found in lib/redis/challenge_searchable.rb and 2 other locations - About 35 mins to fix
    lib/redis/challenge_searchable.rb on lines 132..140
    lib/redis/challenge_searchable.rb on lines 144..152

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 35.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        def redis_key_for_platforms(platforms)
      keys = platforms.map {|p| nest[:platforms][p]}.compact

      if keys.length > 1
        nest[:temp][{platforms: platforms}.hash].tap do |k|
    Severity: Minor
    Found in lib/redis/challenge_searchable.rb and 2 other locations - About 35 mins to fix
    lib/redis/challenge_searchable.rb on lines 120..128
    lib/redis/challenge_searchable.rb on lines 144..152

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 35.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status