Sign upLogin

cmdo/valkyr

View on GitHub
Star

Showing 11 of 16 total issues

Function getPositionalCriteriaFilter has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

function getPositionalCriteriaFilter(
  key: string,
  lKey: string,
  rKey: string,
  criteria: Filter<any>
Severity: Minor
Found in packages/db/src/Storage/Operators/Update/Utils.ts - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getPushFromModifiers has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function getPushFromModifiers(obj: any, values: any[]): any[] {
  if (obj.$each === undefined) {
    return [...values, obj];
  }
  let items: any[];
Severity: Minor
Found in packages/db/src/Storage/Operators/Update/Push.ts - About 1 hr to fix

    Function getPushFromModifiers has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

    function getPushFromModifiers(obj: any, values: any[]): any[] {
  if (obj.$each === undefined) {
    return [...values, obj];
  }
  let items: any[];
    Severity: Minor
    Found in packages/db/src/Storage/Operators/Update/Push.ts - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function validateRequest has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export function validateRequest(request: RequestCandidate): void {
  if (request.jsonrpc !== "2.0") {
    throw new InvalidRequestError({
      reason: "Malformed or missing 'jsonrpc' in request",
      expected: {
    Severity: Minor
    Found in packages/api/src/Validate.ts - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      export class OutdatedEventError<E extends Event = Event> extends Error {
  readonly type = "OutdatedEventError";

  readonly event: E;
      Severity: Minor
      Found in packages/event-store/src/Projector/Errors.ts and 1 other location - About 55 mins to fix
      packages/event-store/src/Projector/Errors.ts on lines 11..20

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 83.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      export class HydratedEventError<E extends Event = Event> extends Error {
  readonly type = "HydratedEventError";

  readonly event: E;
      Severity: Minor
      Found in packages/event-store/src/Projector/Errors.ts and 1 other location - About 55 mins to fix
      packages/event-store/src/Projector/Errors.ts on lines 22..31

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 83.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function getPositionalUpdateQuery has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

        items: any[],
  key: string,
  filter: Filter<any>,
  target: string,
  updateValue: UpdateValue
      Severity: Minor
      Found in packages/db/src/Storage/Operators/Update/Utils.ts - About 35 mins to fix

        Function getPositionalUpdate has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

          items: any[],
  key: string,
  filter: string,
  target: string,
  updateValue: UpdateValue
        Severity: Minor
        Found in packages/db/src/Storage/Operators/Update/Utils.ts - About 35 mins to fix

          Function getPositionalUpdateQuery has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

          export function getPositionalUpdateQuery(
  items: any[],
  key: string,
  filter: Filter<any>,
  target: string,
          Severity: Minor
          Found in packages/db/src/Storage/Operators/Update/Utils.ts - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function $set has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

          export function $set<TSchema extends Document = Document>(
  document: WithId<WithId<TSchema>>,
  filter: Filter<WithId<TSchema>>,
  $set: UpdateFilter<TSchema>["$set"] = {} as any
): boolean {
          Severity: Minor
          Found in packages/db/src/Storage/Operators/Update/Set.ts - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function observe has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

          export function observe<TSchema extends Document = Document>(
  collection: Collection<TSchema>,
  filter: Filter<WithId<TSchema>>,
  options: Options | undefined,
  onChange: (documents: WithId<TSchema>[], changed: WithId<TSchema>[], type: ChangeEvent<TSchema>["type"]) => void
          Severity: Minor
          Found in packages/db/src/Observe/Observe.ts - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language