cmspsgp31/anubis

View on GitHub
anubis/operations/triggers.py

Summary

Maintainability
C
1 day
Test Coverage

Function database_backwards has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def database_backwards(self, app_label, schema_editor, from_state,
Severity: Minor
Found in anubis/operations/triggers.py - About 35 mins to fix

    Function database_forwards has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def database_forwards(self, app_label, schema_editor, from_state,
    Severity: Minor
    Found in anubis/operations/triggers.py - About 35 mins to fix

      Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def __init__(self, model, name, commands, **kwargs):
      Severity: Minor
      Found in anubis/operations/triggers.py - About 35 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        class AddRefreshMaterializedViewTrigger(AddTrigger):
            reduces_to_sql = True
            reversible = True
        
            def __init__(self, trigger_model, materialized_view_model,
        Severity: Major
        Found in anubis/operations/triggers.py and 1 other location - About 3 hrs to fix
        anubis/operations/triggers.py on lines 134..146

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 69.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        class AddRefreshMaterializedViewTableTrigger(AddTableTrigger):
            reduces_to_sql = True
            reversible = True
        
            def __init__(self, trigger_table, materialized_view_model,
        Severity: Major
        Found in anubis/operations/triggers.py and 1 other location - About 3 hrs to fix
        anubis/operations/triggers.py on lines 119..131

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 69.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                self.condition = "" if kwargs.get("condition", None) is None \
                                    else "when ( {} )".format(kwargs["condition"])
        Severity: Major
        Found in anubis/operations/triggers.py and 1 other location - About 1 hr to fix
        anubis/operations/triggers.py on lines 115..116

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 38.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                self.condition = "" if kwargs.get("condition", None) is None \
                                    else "when ( {} )".format(kwargs["condition"])
        Severity: Major
        Found in anubis/operations/triggers.py and 1 other location - About 1 hr to fix
        anubis/operations/triggers.py on lines 52..53

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 38.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status