cnap-cobre/synapse

from django.contrib.auth.models import User, Group
from rest_framework import viewsets
from rest_framework.permissions import IsAuthenticated, AllowAny
from rest_framework.response import Response
from rest_framework.decorators import action
from .serializers import full, basic, anon_create
from .permissions import IsTargetUserOrHasPerm, IsNotAllowed
 
 
class UserViewSet(viewsets.ModelViewSet):
    permission_classes = (IsAuthenticated, )
    queryset = User.objects.all().order_by('-date_joined')
    serializer_class = basic.UserSerializer
    http_method_names = ['get', 'post', 'put', 'patch', 'head', 'options']
 
Cyclomatic complexity is too high in method get_permissions. (6)
    def get_permissions(self):
        """
        - Anyone can create a user and view available methods
        - Updates require permission or ownership
        - Retrieval requires authentication
        - Deletion is not allowed
        """
        if self.action in ['create', 'metadata'] \
                or self.request.method in ['OPTIONS']:
            return AllowAny(),
        elif self.action in ['update', 'partial_update']:
            return IsTargetUserOrHasPerm(),
        elif self.action in ['retrieve', 'list', 'me'] \
                or self.request.method in ['HEAD']:
            return IsAuthenticated(),
        else:
            # 'delete' not allowed
            return IsNotAllowed(),
 
Cyclomatic complexity is too high in method get_serializer_class. (6)
Function `get_serializer_class` has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    def get_serializer_class(self):
        """
        - Limit signup fields for anonymous
        - Expose all fields to privileged users
        - Limit signup fields for non-privileged users
        - Stripped down for everyone else
        """
        if self.request.user.is_anonymous:
            return anon_create.UserSerializer
        elif 'profile.can_view_full_profiles_of_others' \
                in self.request.user.get_all_permissions():
            return full.UserSerializer
        elif self.action == 'create':
            return anon_create.UserSerializer
        elif self.detail:
            obj = self.get_object()
            if obj == self.request.user:
                return full.UserSerializer
Avoid too many `return` statements within this function.
        return basic.UserSerializer
 
    @action(methods=['head', 'get'], detail=False)
    def me(self, request):
        """
        Convenience method to return a user's own profile
        """
        return Response(
            full.UserSerializer(
                self.request.user,
                context={'request': request}
            ).data
        )
 
 
class GroupViewSet(viewsets.ModelViewSet):
    queryset = Group.objects.all()
    serializer_class = full.GroupSerializer
    http_method_names = ['get', 'head', 'options']
 
    def get_permissions(self):
        if self.action in ['retrieve', 'list', 'metadata'] \
                or self.request.method in ['HEAD', 'OPTIONS']:
            return IsAuthenticated(),
        return IsNotAllowed(),