coast-team/netflux

View on GitHub

Showing 73 of 75 total issues

Function setLogLevel has a Cognitive Complexity of 45 (exceeds 5 allowed). Consider refactoring.
Confirmed

export function setLogLevel(...levels: LogLevel[]) {
  logLevels = levels
  if (logLevels.includes(LogLevel.WEB_GROUP)) {
    log.webgroup = (msg: string, ...rest: any[]): void => {
      if (rest.length === 0) {
Severity: Minor
Found in src/misc/util.log.ts - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File WebChannel.ts has 404 lines of code (exceeds 250 allowed). Consider refactoring.
Confirmed

import { Observable, Subject } from 'rxjs'

import { Channel } from './Channel'
import {
  extractHostnameAndPort,
Severity: Minor
Found in src/WebChannel.ts - About 5 hrs to fix

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

      if (logLevels.includes(LogLevel.TOPOLOGY)) {
        log.topology = (msg: string, ...rest: any[]) => {
          if (rest.length === 0) {
            console.info(`%cNETFLUX Topology%c: ${msg}`, topologyCSS, '')
          } else {
    Severity: Major
    Found in src/misc/util.log.ts and 4 other locations - About 5 hrs to fix
    src/misc/util.log.ts on lines 85..95
    src/misc/util.log.ts on lines 98..108
    src/misc/util.log.ts on lines 124..134
    src/misc/util.log.ts on lines 137..147

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 139.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

      if (logLevels.includes(LogLevel.SIGNALING)) {
        log.signaling = (msg: string, ...rest: any[]) => {
          if (rest.length === 0) {
            console.info(`%cNETFLUX Signaling%c: ${msg}`, signalingCSS, '')
          } else {
    Severity: Major
    Found in src/misc/util.log.ts and 4 other locations - About 5 hrs to fix
    src/misc/util.log.ts on lines 85..95
    src/misc/util.log.ts on lines 98..108
    src/misc/util.log.ts on lines 111..121
    src/misc/util.log.ts on lines 137..147

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 139.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

      if (logLevels.includes(LogLevel.CHANNEL_BUILDER)) {
        log.channelBuilder = (msg: string, ...rest: any[]) => {
          if (rest.length === 0) {
            console.info(`%cNETFLUX ChannelBuilder%c: ${msg}`, channelBuilderCSS, '')
          } else {
    Severity: Major
    Found in src/misc/util.log.ts and 4 other locations - About 5 hrs to fix
    src/misc/util.log.ts on lines 85..95
    src/misc/util.log.ts on lines 98..108
    src/misc/util.log.ts on lines 111..121
    src/misc/util.log.ts on lines 124..134

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 139.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

      if (logLevels.includes(LogLevel.CHANNEL)) {
        log.channel = (msg: string, ...rest: any[]) => {
          if (rest.length === 0) {
            console.info(`%cNETFLUX Channel%c: ${msg}`, channelCSS, '')
          } else {
    Severity: Major
    Found in src/misc/util.log.ts and 4 other locations - About 5 hrs to fix
    src/misc/util.log.ts on lines 85..95
    src/misc/util.log.ts on lines 111..121
    src/misc/util.log.ts on lines 124..134
    src/misc/util.log.ts on lines 137..147

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 139.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

      if (logLevels.includes(LogLevel.WEBRTC)) {
        log.webrtc = (msg: string, ...rest: any[]) => {
          if (rest.length === 0) {
            console.info(`%cNETFLUX WebRTC%c: ${msg}`, webrtcCSS, '')
          } else {
    Severity: Major
    Found in src/misc/util.log.ts and 4 other locations - About 5 hrs to fix
    src/misc/util.log.ts on lines 98..108
    src/misc/util.log.ts on lines 111..121
    src/misc/util.log.ts on lines 124..134
    src/misc/util.log.ts on lines 137..147

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 139.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function constructor has 114 lines of code (exceeds 25 allowed). Consider refactoring.
    Confirmed

      constructor(options: WebGroupOptions = {}) {
        const wc = new WebChannel(options)
        wcs.set(this, wc)
    
        /**
    Severity: Major
    Found in src/WebChannelFacade.ts - About 4 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          Reflect.defineProperty(this, 'onError', {
            configurable: true,
            enumerable: true,
            get: () => (botServer.onError.name === 'none' ? undefined : botServer.onError),
            set: (handler: (err: Error) => void) => {
      Severity: Major
      Found in src/BotFacade.ts and 1 other location - About 4 hrs to fix
      src/BotFacade.ts on lines 133..144

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 126.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          Reflect.defineProperty(this, 'onWebGroup', {
            configurable: true,
            enumerable: true,
            get: () => (botServer.onWebGroup.name === 'none' ? undefined : botServer.onWebGroup),
            set: (handler: (wg: WebGroup) => void) => {
      Severity: Major
      Found in src/BotFacade.ts and 1 other location - About 4 hrs to fix
      src/BotFacade.ts on lines 151..162

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 126.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      File FullMesh.ts has 348 lines of code (exceeds 250 allowed). Consider refactoring.
      Confirmed

      import { Channel, IChannelInitData, MAXIMUM_MISSED_HEARTBEAT } from '../../Channel'
      import { isBrowser, log } from '../../misc/util'
      import { fullMesh as proto } from '../../proto/index'
      import { InWcMsg, WebChannel } from '../../WebChannel'
      import { ConnectionError } from '../channelBuilder/ConnectionError'
      Severity: Minor
      Found in src/service/topology/FullMesh.ts - About 4 hrs to fix

        Function setLogLevel has 105 lines of code (exceeds 25 allowed). Consider refactoring.
        Confirmed

        export function setLogLevel(...levels: LogLevel[]) {
          logLevels = levels
          if (logLevels.includes(LogLevel.WEB_GROUP)) {
            log.webgroup = (msg: string, ...rest: any[]): void => {
              if (rest.length === 0) {
        Severity: Major
        Found in src/misc/util.log.ts - About 4 hrs to fix

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

              Reflect.defineProperty(this, 'onMyId', {
                configurable: true,
                enumerable: true,
                get: () => (wc.onMyId.name === 'none' ? undefined : wc.onMyId),
                set: (handler: (myId: number) => void) => {
          Severity: Major
          Found in src/WebChannelFacade.ts and 2 other locations - About 3 hrs to fix
          src/WebChannelFacade.ts on lines 221..228
          src/WebChannelFacade.ts on lines 234..241

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 111.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

              Reflect.defineProperty(this, 'onMemberJoin', {
                configurable: true,
                enumerable: true,
                get: () => (wc.onMemberJoin.name === 'none' ? undefined : wc.onMemberJoin),
                set: (handler: (id: number) => void) => {
          Severity: Major
          Found in src/WebChannelFacade.ts and 2 other locations - About 3 hrs to fix
          src/WebChannelFacade.ts on lines 208..215
          src/WebChannelFacade.ts on lines 234..241

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 111.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

              Reflect.defineProperty(this, 'onMemberLeave', {
                configurable: true,
                enumerable: true,
                get: () => (wc.onMemberLeave.name === 'none' ? undefined : wc.onMemberLeave),
                set: (handler: (id: number) => void) => {
          Severity: Major
          Found in src/WebChannelFacade.ts and 2 other locations - About 3 hrs to fix
          src/WebChannelFacade.ts on lines 208..215
          src/WebChannelFacade.ts on lines 221..228

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 111.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              Reflect.defineProperty(this, 'onSignalingStateChange', {
                configurable: true,
                enumerable: true,
                get: () =>
                  wc.onSignalingStateChange.name === 'none' ? undefined : wc.onSignalingStateChange,
          Severity: Major
          Found in src/WebChannelFacade.ts and 1 other location - About 3 hrs to fix
          src/WebChannelFacade.ts on lines 247..254

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 110.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              Reflect.defineProperty(this, 'onStateChange', {
                configurable: true,
                enumerable: true,
                get: () => (wc.onStateChange.name === 'none' ? undefined : wc.onStateChange),
                set: (handler: (state: WebChannelState) => void) => {
          Severity: Major
          Found in src/WebChannelFacade.ts and 1 other location - About 3 hrs to fix
          src/WebChannelFacade.ts on lines 260..268

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 110.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          File ChannelBuilder.ts has 322 lines of code (exceeds 250 allowed). Consider refactoring.
          Confirmed

          import { merge, Observable, Subject } from 'rxjs'
          
          import { Channel } from '../../Channel'
          import { isWebRTCSupported, isWebSocketSupported, log } from '../../misc/util'
          import { channelBuilder as proto } from '../../proto/index'
          Severity: Minor
          Found in src/service/channelBuilder/ChannelBuilder.ts - About 3 hrs to fix

            Function handleMessage has 91 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              private handleMessage(
                streamId: number,
                senderId: number,
                recipientId: number,
                msg: proto.Message
            Severity: Major
            Found in src/service/channelBuilder/ChannelBuilder.ts - About 3 hrs to fix

              Function handleMessage has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
              Open

                private handleMessage(
                  streamId: number,
                  senderId: number,
                  recipientId: number,
                  msg: proto.Message
              Severity: Minor
              Found in src/service/channelBuilder/ChannelBuilder.ts - About 3 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Severity
              Category
              Status
              Source
              Language